From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8DAF3C54FCB for ; Fri, 24 Apr 2020 19:41:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6A97A2173E for ; Fri, 24 Apr 2020 19:41:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="T0keOgZ7" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729175AbgDXTlt (ORCPT ); Fri, 24 Apr 2020 15:41:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36170 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729204AbgDXTls (ORCPT ); Fri, 24 Apr 2020 15:41:48 -0400 Received: from mail-lj1-x241.google.com (mail-lj1-x241.google.com [IPv6:2a00:1450:4864:20::241]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 04400C09B049 for ; Fri, 24 Apr 2020 12:41:48 -0700 (PDT) Received: by mail-lj1-x241.google.com with SMTP id u6so11180116ljl.6 for ; Fri, 24 Apr 2020 12:41:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=xEmEzSJAW12x5niGKKzPXSqsRmQBFq2lP6H8xvuac/8=; b=T0keOgZ72bgaeEiqotFnnG+NMkzgKYHGXH4TyFbkmZQOJe1Y5iKcFbRjOuVS3LytBL W6AnOWDW2QWZo3w+XoSlX7QKg7WFduDC+turDLabtmC3eHu2R+LW2LppYuJYXdj40rg7 CdC1QLOEEL0R1Cimqms8CMRslN8tW7OXjqcp181VPdrvY8W8QYwXkvlGnezntNU/aIQI i6YsVJ+qBo1IpmfuneESoyprPvhhXr26CeMvNdDtUxyovd7PslG1FH6YR8sVB7ohtRad QOWlk/axNwWA9QPd0lqbh3Eau8RDrkadohiHGyCxCHAzXRPCkwjqYlFo45dJvWYiXb2y 7ahA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=xEmEzSJAW12x5niGKKzPXSqsRmQBFq2lP6H8xvuac/8=; b=Uqy2XTKiLB8ayGMQ2o5J2FUVBBUWkoPiT8v84tWaH+a9KkMFa+scLyOBN2oavKDoKJ LFFf6wSbUnXoIbmdJdzyqbelSz5aXVZEugYY0El4WpeWmzWl9xscZBUkAh+X1CG5udzW Di645xjCWgyPjHN17tiZzNoeGP1AGfVuqaNuiP3z6EXrovtcFUtJOW3tRjubc0tx6viT ySf7vj/YpUW4jaJvhC55YuHuMWfEJIuO490lbcmRNm4VEL88dH2nR5WjsNOkWRyhduXK 87eA/VyVZtbDwFndp28ZFCIO+whk031k8tiAqpLwdGJgfe5mH2fF86jeMYoFklmwDSNO Cf/g== X-Gm-Message-State: AGi0PubP/ZMbttz6UoHq/wtNoVteyOEcyzskSwtqoUC0seJtvkajsra8 PNbD3TZFzjvcBW/ne1NyIO+w3lPByBTRGXIxS/ZVjw== X-Google-Smtp-Source: APiQypI4Xi6+DbAAYIeOQPzrEcE/mxStfNg2RlTAQ/87ko7Y+RTOVwvrDrzFbofvytmtXUu0lTzmeVzRLH+KYXFDMfY= X-Received: by 2002:a2e:9791:: with SMTP id y17mr7027497lji.174.1587757306172; Fri, 24 Apr 2020 12:41:46 -0700 (PDT) MIME-Version: 1.0 References: <20200328185916.98423-1-rajatja@google.com> <20200328185916.98423-3-rajatja@google.com> <20200410164140.GA25924@bogus> In-Reply-To: <20200410164140.GA25924@bogus> From: Rajat Jain Date: Fri, 24 Apr 2020 12:41:09 -0700 Message-ID: Subject: Re: [PATCH v4 3/5] dt-bindings: input/atkbd.txt: Add binding for "function-row-physmap" To: Rob Herring Cc: Dmitry Torokhov , Dmitry Torokhov , Mark Rutland , Kate Stewart , Enrico Weigelt , Greg Kroah-Hartman , Thomas Gleixner , Allison Randal , "Rafael J. Wysocki" , Stephen Boyd , linux-input , devicetree@vger.kernel.org, Linux Kernel Mailing List , Furquan Shaikh , Duncan Laurie , Benson Leung , Zentaro Kavanagh , Dominik Behr , Rajat Jain Content-Type: text/plain; charset="UTF-8" Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Hi, On Fri, Apr 10, 2020 at 10:38 AM Rob Herring wrote: > > On Sat, Mar 28, 2020 at 11:59:14AM -0700, Rajat Jain wrote: > > Create the documentation for the new introduced property, that > > describes the function-row keys physical positions. > > > > Signed-off-by: Rajat Jain > > --- > > v4: Same as v3 > > v3: same as v2 > > v2: Remove the Change-Id from the commit log > > > > .../devicetree/bindings/input/atkbd.txt | 34 +++++++++++++++++++ > > 1 file changed, 34 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/input/atkbd.txt > > > > diff --git a/Documentation/devicetree/bindings/input/atkbd.txt b/Documentation/devicetree/bindings/input/atkbd.txt > > new file mode 100644 > > index 0000000000000..816653eb8e98d > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/input/atkbd.txt > > @@ -0,0 +1,34 @@ > > +Device tree bindings for AT / PS2 keyboard device > > + > > +Optional properties: > > + > > + function-row-physmap: > > + An ordered array of the physical codes for the function > > + row keys. Arranged in order from left to right. > > A single optional property doesn't constitute a DT binding. > > > + > > +Example: > > + > > + This is a sample ACPI _DSD node describing the property: > > Neither does this ACPI stuff. I assume this means a nack to the documentation patches. Dmitry, can you apply the other patches in the series? Thanks, Rajat > > Rob