From: Linus Walleij <linus.walleij@linaro.org>
To: Andrew Duggan <aduggan@synaptics.com>
Cc: Linux Input <linux-input@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Benjamin Tissoires <benjamin.tissoires@gmail.com>,
Christopher Heiny <cheiny@synaptics.com>,
Stephen Chandler Paul <cpaul@redhat.com>
Subject: Re: [PATCH 26/26] Input: synaptics-rmi4: Change the rmi device's name to be less generic
Date: Mon, 9 Nov 2015 14:38:02 +0100 [thread overview]
Message-ID: <CACRpkdY6FxZWv4fKkYA98SeM40BGimOVi04phDjRGyAdBbPXFA@mail.gmail.com> (raw)
In-Reply-To: <1446767000-31398-1-git-send-email-aduggan@synaptics.com>
On Fri, Nov 6, 2015 at 12:43 AM, Andrew Duggan <aduggan@synaptics.com> wrote:
> Currently, the rmi device has the name sensorXX. Sensor is very generic
> and in cases when there is little context it is hard to tell what the
> device is (ie in /sys/devices or /proc/interrupts). This patch changes
> the name to rmiXX which at least indicates that it is an rmi device.
>
> Signed-off-by: Andrew Duggan <aduggan@synaptics.com>
> ---
> Linus Walleij suggested that we use the TM number as the device name.
> But, we need to set the device name when we add the device before we
> read the TM number. Changing the name to rmiXX is a compromise since
> it's not as unique as the TM, but not as generic as sensor.
OK OK I give up. No big deal anyway, the device works.
Squash into core patch?
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
prev parent reply other threads:[~2015-11-09 13:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-05 23:43 [PATCH 26/26] Input: synaptics-rmi4: Change the rmi device's name to be less generic Andrew Duggan
2015-11-09 13:38 ` Linus Walleij [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdY6FxZWv4fKkYA98SeM40BGimOVi04phDjRGyAdBbPXFA@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=aduggan@synaptics.com \
--cc=benjamin.tissoires@gmail.com \
--cc=cheiny@synaptics.com \
--cc=cpaul@redhat.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).