From: Linus Walleij <linus.walleij@linaro.org>
To: Alexander Stein <alexander.stein@systec-electronic.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
Alexandre Courbot <gnurou@gmail.com>,
Linux Input <linux-input@vger.kernel.org>
Subject: Re: gpio irqchip initialization race
Date: Fri, 1 Apr 2016 13:29:14 +0200 [thread overview]
Message-ID: <CACRpkdYeMdUtqizXGFzLDwbiL7=xDM+tt0kQU5S166AL13Y_1Q@mail.gmail.com> (raw)
In-Reply-To: <1587936.Xd43Z6OAxQ@ws-stein>
On Fri, Apr 1, 2016 at 10:56 AM, Alexander Stein
<alexander.stein@systec-electronic.com> wrote:
> [Me]
>> And in this case (if gpio_keys handle -EPROBE_DEFER gracefully)
>> all should be fine with my oneliner patch.
>>
>> I am more uncertain about the -EINVAL (-22) we might need some
>> more analysis there.
>
> I did 10 runs and got the following results:
>> 3x gpio-keys user_sw: Unable to claim irq 0; error -22
>> 2x gpio-keys user_sw: Unable to get irq number for GPIO 376, error -517
>> 5x ok
>
> So, for one gpio-keys seems not to handle -EPROBE_DEFER gracefully
After reading the code the only problem seems to be that it prints that
error. A small patch to silence that print should fix it then, can you
confirm that in these cases the gpio-keys are retried later?
> and it seem
> still possible to get an invalid irq number.
I think this is because gpiolib initialize .to_irq() before setting up the
irqdomain.
I'm making a combined patch fixing both issues, send out in a few sec.
Yours,
Linus Walleij
next prev parent reply other threads:[~2016-04-01 11:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <44236018.b6N0xPzKYW@ws-stein>
2016-04-01 8:43 ` gpio irqchip initialization race Linus Walleij
2016-04-01 8:47 ` Linus Walleij
2016-04-01 8:56 ` Alexander Stein
2016-04-01 11:29 ` Linus Walleij [this message]
2016-04-01 12:45 ` Alexander Stein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACRpkdYeMdUtqizXGFzLDwbiL7=xDM+tt0kQU5S166AL13Y_1Q@mail.gmail.com' \
--to=linus.walleij@linaro.org \
--cc=alexander.stein@systec-electronic.com \
--cc=dmitry.torokhov@gmail.com \
--cc=gnurou@gmail.com \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).