From: Linus Walleij <linus.walleij@linaro.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Linux Input <linux-input@vger.kernel.org>,
Darren Hart <dvhart@infradead.org>,
platform-driver-x86 <platform-driver-x86@vger.kernel.org>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1 1/4] gpio: acpi: Don't return 0 on acpi_gpio_count()
Date: Thu, 16 Mar 2017 15:42:51 +0100 [thread overview]
Message-ID: <CACRpkdZLYeSuM+geLJgDOa2FXwP8mWXs-tmi6vQjRBtMpoJUwA@mail.gmail.com> (raw)
In-Reply-To: <20170220161549.39490-2-andriy.shevchenko@linux.intel.com>
On Mon, Feb 20, 2017 at 5:15 PM, Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
> It's unusual to have error checking like (ret <= 0) in cases when
> counting GPIO resources. In case when it's mandatory we propagate the
> error (-ENOENT), otherwise we don't use the result.
>
> This makes consistent behaviour across all possible variants called in
> gpiod_count().
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Patch applied with Mika's ACK.
Yours,
Linus Walleij
next prev parent reply other threads:[~2017-03-16 14:42 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-20 16:15 [PATCH v1 0/4] gpio: make gpiod_count() API consistent Andy Shevchenko
2017-02-20 16:15 ` [PATCH v1 1/4] gpio: acpi: Don't return 0 on acpi_gpio_count() Andy Shevchenko
2017-03-14 9:43 ` Linus Walleij
2017-03-14 11:51 ` Mika Westerberg
2017-03-16 14:42 ` Linus Walleij [this message]
2017-02-20 16:15 ` [PATCH v1 2/4] gpio: of: Don't return 0 on dt_gpio_count() Andy Shevchenko
2017-03-16 14:43 ` Linus Walleij
2017-02-20 16:15 ` [PATCH v1 3/4] platform/x86: surface3_button: Propagate error from gpiod_count() Andy Shevchenko
2017-03-14 9:46 ` Linus Walleij
2017-03-14 12:28 ` Andy Shevchenko
2017-03-16 14:45 ` Linus Walleij
2017-02-20 16:15 ` [PATCH v1 4/4] Input: soc_button_array - " Andy Shevchenko
2017-02-23 8:40 ` Dmitry Torokhov
2017-03-16 14:46 ` Linus Walleij
2017-02-27 8:27 ` [PATCH v1 0/4] gpio: make gpiod_count() API consistent Benjamin Tissoires
2017-02-28 9:48 ` Andy Shevchenko
2017-03-14 9:49 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdZLYeSuM+geLJgDOa2FXwP8mWXs-tmi6vQjRBtMpoJUwA@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=benjamin.tissoires@redhat.com \
--cc=dmitry.torokhov@gmail.com \
--cc=dvhart@infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).