From: Linus Walleij <linus.walleij@linaro.org>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Aaro Koskinen <aaro.koskinen@iki.fi>,
Janusz Krzysztofik <jmkrzyszt@gmail.com>,
Tony Lindgren <tony@atomide.com>,
Russell King <linux@armlinux.org.uk>,
Daniel Mack <daniel@zonque.org>,
Haojian Zhuang <haojian.zhuang@gmail.com>,
Robert Jarzmik <robert.jarzmik@free.fr>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Mark Brown <broonie@kernel.org>,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>,
Andreas Kemnade <andreas@kemnade.info>,
Helge Deller <deller@gmx.de>,
Ulf Hansson <ulf.hansson@linaro.org>,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org,
linux-input@vger.kernel.org, linux-spi@vger.kernel.org,
linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-mmc@vger.kernel.org
Subject: Re: [PATCH v3 1/3] Input: ads7846 - Convert to use software nodes
Date: Mon, 8 May 2023 23:31:06 +0200 [thread overview]
Message-ID: <CACRpkdae4+0vsJS71G6dR5PEpMw13JGJAJr9Jyf2T+Z8gOgoxQ@mail.gmail.com> (raw)
In-Reply-To: <ZFlpYff6I5V6JiH1@google.com>
On Mon, May 8, 2023 at 11:28 PM Dmitry Torokhov
<dmitry.torokhov@gmail.com> wrote:
> On Mon, May 08, 2023 at 11:23:44PM +0200, Linus Walleij wrote:
> > > This needs to be
> > >
> > > return !gpiod_get_value_raw(ts->gpio_pendown);
> >
> > There is no such function. The gpio descriptor runpath simply assumes that
> > device trees can be trusted.
>
> Sorry, this was supposed to be gpiod_get_raw_value():
>
> https://elixir.bootlin.com/linux/latest/source/drivers/gpio/gpiolib.c#L2854
I missed it, I should have very well understood you meant that one...
I just read the file too sloppily.
> Yeah, we we can land the DT fixes ahead of the driver change that would
> be great. Otherwise we need a temporary application of
> gpiod_get_raw_value().
If the patch is fine I will send it to the SoC tree and ask for it to be
applied as a fix.
Yours,
Linus Walleij
next prev parent reply other threads:[~2023-05-08 21:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-05 11:16 [PATCH v3 0/3] Fix up Nokia 770 regression Linus Walleij
2023-05-05 11:16 ` [PATCH v3 1/3] Input: ads7846 - Convert to use software nodes Linus Walleij
2023-05-05 18:08 ` Dmitry Torokhov
2023-05-08 21:23 ` Linus Walleij
2023-05-08 21:28 ` Dmitry Torokhov
2023-05-08 21:31 ` Linus Walleij [this message]
2023-05-08 15:16 ` andy.shevchenko
2023-05-08 20:54 ` Linus Walleij
2023-05-05 11:16 ` [PATCH v3 2/3] ARM/mmc: Convert old mmci-omap to GPIO descriptors Linus Walleij
2023-05-05 11:16 ` [PATCH v3 3/3] ARM: omap1: Fix up the Nokia 770 board device IRQs Linus Walleij
2023-05-08 15:17 ` andy.shevchenko
2023-05-08 21:28 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdae4+0vsJS71G6dR5PEpMw13JGJAJr9Jyf2T+Z8gOgoxQ@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=aaro.koskinen@iki.fi \
--cc=andreas@kemnade.info \
--cc=bartosz.golaszewski@linaro.org \
--cc=broonie@kernel.org \
--cc=daniel@zonque.org \
--cc=deller@gmx.de \
--cc=dmitry.torokhov@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=haojian.zhuang@gmail.com \
--cc=jmkrzyszt@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=robert.jarzmik@free.fr \
--cc=tony@atomide.com \
--cc=tsbogend@alpha.franken.de \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).