From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 180DBC7EE2C for ; Mon, 8 May 2023 21:31:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233957AbjEHVbW (ORCPT ); Mon, 8 May 2023 17:31:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42882 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233921AbjEHVbU (ORCPT ); Mon, 8 May 2023 17:31:20 -0400 Received: from mail-yb1-xb30.google.com (mail-yb1-xb30.google.com [IPv6:2607:f8b0:4864:20::b30]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 542A786A5 for ; Mon, 8 May 2023 14:31:18 -0700 (PDT) Received: by mail-yb1-xb30.google.com with SMTP id 3f1490d57ef6-b9a6eec8611so27425110276.0 for ; Mon, 08 May 2023 14:31:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1683581477; x=1686173477; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=mOJR/20LVKyz48EAyeHc1+jVArD8eFRaiPVz2llKJYw=; b=xnPwIs1cwDo2FfYER/sCJ/da+7w70ojR2vcIjoTIwWXCv32mMF1zm1BD4+lfb2YBZM a2JVJMgplb8WbXqgCdHgK8Kp72gs89jO2wf+8i72UAlWKsMEO+QAvE2kzbL6W+zsK4XX 5Z8iTG2eG+u2fgFxWPNmnpwDmCvRMpfx0fMcptbYfNamY9350JY8Gd4qdqq2mPQh9kC0 +x56ZfIKBMwAlE8P63WHOLZVXUP3U77r1pEjelQEPWycVNYaZZsW7RV6EqwWY1pIciet mUJNXjEV6P9b/N9Sms+auwR08F+s4xsHpxn7JhrpRdBY15Z66VnYReC0HO7LXkTpsCWj 0ulg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683581477; x=1686173477; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mOJR/20LVKyz48EAyeHc1+jVArD8eFRaiPVz2llKJYw=; b=kCGA4/1yiV0LXpBLUnQ/R8q1T4vOsBUIngeM6rRJMFCuO8zU5PHhOeN7AJBZebhZmt lNYvIS8Pxzt8EkvqRSzSQCd1VsngU0jHFannuK08/F1p6CICjdlknrqBsFjuafVClB90 8w0qBVqRJOH/0fv/J5s5mev+XKmj2aHiKbaPkAKcoLeuo0FdBBO/njUiq3ClRRETGa9O tLZ41kfH11OTKRckeSvANjEI/I/Imfht5IVAhWLXO0rReJsgcrMkNDHE4KotIvb0hg5i JB/C7rY9O/mu5fGaMhL1e5oP9XO0sFRePMOV+BPuvWBFGXTYsO9fQ4POTjiEV8h9WDQ9 tahA== X-Gm-Message-State: AC+VfDydM36tbzzsFzfKvebJh8gnRTZgH6MQqovZYrlYxOSO20ryHDgm vowN+9Axp73NzG+1B6PWYbvL/rk0bJ6aYyu+89B/Ww== X-Google-Smtp-Source: ACHHUZ58fReQQ4pRCBtoCz9Lw0P3GVuCrDW/FKsG0+nk/YgPWCXp8EO7CBeqYU//QyxCun6JDuY2iPWmdeq6/W2Qfd0= X-Received: by 2002:a81:4c4c:0:b0:54f:54c5:70d with SMTP id z73-20020a814c4c000000b0054f54c5070dmr13840092ywa.20.1683581477497; Mon, 08 May 2023 14:31:17 -0700 (PDT) MIME-Version: 1.0 References: <20230430-nokia770-regression-v3-0-a6d0a89ffa8b@linaro.org> <20230430-nokia770-regression-v3-1-a6d0a89ffa8b@linaro.org> In-Reply-To: From: Linus Walleij Date: Mon, 8 May 2023 23:31:06 +0200 Message-ID: Subject: Re: [PATCH v3 1/3] Input: ads7846 - Convert to use software nodes To: Dmitry Torokhov Cc: Aaro Koskinen , Janusz Krzysztofik , Tony Lindgren , Russell King , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Thomas Bogendoerfer , Mark Brown , Bartosz Golaszewski , Andreas Kemnade , Helge Deller , Ulf Hansson , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-input@vger.kernel.org, linux-spi@vger.kernel.org, linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-mmc@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org On Mon, May 8, 2023 at 11:28=E2=80=AFPM Dmitry Torokhov wrote: > On Mon, May 08, 2023 at 11:23:44PM +0200, Linus Walleij wrote: > > > This needs to be > > > > > > return !gpiod_get_value_raw(ts->gpio_pendown); > > > > There is no such function. The gpio descriptor runpath simply assumes t= hat > > device trees can be trusted. > > Sorry, this was supposed to be gpiod_get_raw_value(): > > https://elixir.bootlin.com/linux/latest/source/drivers/gpio/gpiolib.c#L28= 54 I missed it, I should have very well understood you meant that one... I just read the file too sloppily. > Yeah, we we can land the DT fixes ahead of the driver change that would > be great. Otherwise we need a temporary application of > gpiod_get_raw_value(). If the patch is fine I will send it to the SoC tree and ask for it to be applied as a fix. Yours, Linus Walleij