From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Walleij Subject: Re: [PATCH] gpiolib: handle probe deferrals better Date: Fri, 1 Apr 2016 15:03:40 +0200 Message-ID: References: <1459511048-24084-1-git-send-email-linus.walleij@linaro.org> <1766024.riJEdmHPZI@ws-stein> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: Received: from mail-oi0-f45.google.com ([209.85.218.45]:33466 "EHLO mail-oi0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758899AbcDANDl (ORCPT ); Fri, 1 Apr 2016 09:03:41 -0400 Received: by mail-oi0-f45.google.com with SMTP id d205so104149524oia.0 for ; Fri, 01 Apr 2016 06:03:41 -0700 (PDT) In-Reply-To: <1766024.riJEdmHPZI@ws-stein> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Alexander Stein Cc: "linux-gpio@vger.kernel.org" , Alexandre Courbot , Linux Input , Tomeu Vizoso , Guenter Roeck On Fri, Apr 1, 2016 at 2:16 PM, Alexander Stein wrote: > I noticed you fiddle with late_initcall_sync. Sorry, I did not mention it: > gpio_mcp23s08 as well as gpio_keys are loaded as modules, so late_initcall_* > should not affect it. I don't get this. I think probe deferral is only used to defer initcalls used for built-in drivers. If there are dependencies among things compiled as modules, doesn't depmod/modprobe make sure that they are probed in the right order? Could it be that some module alias thingofabob is missing? Or is modprobe failing because it (correctly) see that there is no symbol dependencies between the gpio_mcp23s08 and gpio-keys modules? (Not that I know how depmod works...) If nothing else works, I guess marking mcp23s08 as bool and building it into the kernel will work, right? Yours, Linus Walleij