[PATCH] Input: cyttsp - do not force interrupt trigger

[PATCH] Input: cyttsp - do not force interrupt trigger

[Dmitry Torokhov]

Instead of forcing interrupt trigger to be "falling edge" let's rely on the
platform to set it up according to how it is set up on a given board based
on data in device tree or ACPI tables.

Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---

Linus, Ferruh's email has been bouncing for ages, it looks like you have
the hardware and you are already looking over another Cypress touch
controller, mind if I put you down as a maintainer for this one as well?


 drivers/input/touchscreen/cyttsp_core.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/input/touchscreen/cyttsp_core.c b/drivers/input/touchscreen/cyttsp_core.c
index d9debcdeeec7..a6352d79e23d 100644
--- a/drivers/input/touchscreen/cyttsp_core.c
+++ b/drivers/input/touchscreen/cyttsp_core.c
@@ -699,8 +699,7 @@ struct cyttsp *cyttsp_probe(const struct cyttsp_bus_ops *bus_ops,
 	}
 
 	error = devm_request_threaded_irq(dev, ts->irq, NULL, cyttsp_irq,
-					  IRQF_TRIGGER_FALLING | IRQF_ONESHOT |
-					  IRQF_NO_AUTOEN,
+					  IRQF_ONESHOT | IRQF_NO_AUTOEN,
 					  "cyttsp", ts);
 	if (error) {
 		dev_err(ts->dev, "failed to request IRQ %d, err: %d\n",
-- 
2.31.1.818.g46aad6cb9e-goog


-- 
Dmitry

Re: [PATCH] Input: cyttsp - do not force interrupt trigger

[Linus Walleij]

On Thu, May 27, 2021 at 2:05 AM Dmitry Torokhov
<dmitry.torokhov@gmail.com> wrote:

> Instead of forcing interrupt trigger to be "falling edge" let's rely on the
> platform to set it up according to how it is set up on a given board based
> on data in device tree or ACPI tables.
>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

> Linus, Ferruh's email has been bouncing for ages, it looks like you have
> the hardware and you are already looking over another Cypress touch
> controller, mind if I put you down as a maintainer for this one as well?

That's fine, just list me if you want, one more or less.

Yours,
Linus Walleij