From: Linus Walleij <linus.walleij@linaro.org>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@vger.kernel.org, Nikita Travkin <nikita@trvn.ru>,
Michael Srba <Michael.Srba@seznam.cz>
Subject: Re: [PATCH 1/5] Input: zinitix - Helper dev variable in probe()
Date: Fri, 27 May 2022 15:30:22 +0200 [thread overview]
Message-ID: <CACRpkdbLpjdGaUnCYExJbKYfvTSAVh6Ugvq4bcb_=kOXDXKtKA@mail.gmail.com> (raw)
In-Reply-To: <YpBjatmHD6hZgDGx@google.com>
On Fri, May 27, 2022 at 7:36 AM Dmitry Torokhov
<dmitry.torokhov@gmail.com> wrote:
> On Sun, Apr 10, 2022 at 02:00:55PM +0200, Linus Walleij wrote:
> > Create a helper variable struct device *dev in probe() to
> > make the code more compact and easier to read.
>
> Actually I wonder if this is a good idea: when just seeing "dev" I often
> have hard time to remember what device we are dealing with, whereas
> "client->dev" gives a very string hint that we are dealing with I2C
> peripheral physical device.
Hm yeah that has a point I suppose.
> Did you observe object code savings from the conversion by chance?
No it is just cognitively easier for me (less characters on the screen)
but that is admittedly a bit of personal preference.
I'll drop this patch, because the subsystem maintainer's taste is
more important than mine.
Yours,
Linus Walleij
prev parent reply other threads:[~2022-05-27 13:30 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-10 12:00 [PATCH 1/5] Input: zinitix - Helper dev variable in probe() Linus Walleij
2022-04-10 12:00 ` [PATCH 2/5] Input: zinitix - Add dev variable in state Linus Walleij
2022-05-27 5:37 ` Dmitry Torokhov
2022-05-27 13:31 ` Linus Walleij
2022-04-10 12:00 ` [PATCH 3/5] Input: zinitix - Rename defines ZINITIX_* Linus Walleij
2022-05-27 5:48 ` Dmitry Torokhov
2022-04-10 12:00 ` [PATCH 4/5] Input: zinitix - Read and cache device version numbers Linus Walleij
2022-05-27 5:47 ` Dmitry Torokhov
2022-04-10 12:00 ` [PATCH 5/5] Input: zinitix - Support calibration Linus Walleij
2022-05-27 5:48 ` Dmitry Torokhov
2022-05-24 12:08 ` [PATCH 1/5] Input: zinitix - Helper dev variable in probe() Linus Walleij
2022-05-27 5:36 ` Dmitry Torokhov
2022-05-27 13:30 ` Linus Walleij [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACRpkdbLpjdGaUnCYExJbKYfvTSAVh6Ugvq4bcb_=kOXDXKtKA@mail.gmail.com' \
--to=linus.walleij@linaro.org \
--cc=Michael.Srba@seznam.cz \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=nikita@trvn.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).