From mboxrd@z Thu Jan 1 00:00:00 1970 From: Elias Vanderstuyft Subject: Re: [PATCH v4 01/24] input: Add ff-memless-next module Date: Tue, 20 May 2014 23:26:54 +0200 Message-ID: References: <1398524543-15012-1-git-send-email-madcatxster@devoid-pointer.net> <2965006.XKYHWj9YzJ@sigyn> <865ad8dbc7ae0d13c045bd2a85cff2e2.squirrel@mungewell.org> <6970969.ej8OFzkVkO@sigyn> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <6970969.ej8OFzkVkO@sigyn> Sender: linux-kernel-owner@vger.kernel.org To: Dmitry Torokhov Cc: Simon Wood , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Jiri Kosina , Anssi Hannula , =?UTF-8?B?TWljaGFsIE1hbMO9?= List-Id: linux-input@vger.kernel.org On Tue, May 20, 2014 at 10:58 PM, Michal Mal=C3=BD wrote: > On Tuesday 20 of May 2014 16:16:12 simon@mungewell.org wrote: >> Regarding the question of emulated vs. real effects, can we extend t= he API >> so that applications can know which effects are really supported, an= d >> enable/disable emulation somehow? > > I suppose that a few extra flags (FF_PERIODIC_EMULATED etc.) defined = in > "uapi/linux/input.h" should suffice. @Dmitry: Now that we're talking about API changes, I would like to propose some additional things in the Linux FF API: - Possibility to *get* FF state variables, such as the value of the current GAIN, and the current AUTOCENTER: At the moment, only *setting* is possible. This poses a problem when implementing proper AUTOCENTER state recovery (upon closing a Windows program) in Wine, because the initial AUTOCENTER state was unknown. The same applies for GAIN. - Introduce multiple types of GAIN, apart from the current global GAIN, e.g. GAIN_CONSTANT and GAIN_DAMPER: This is mainly on request of some users, especially Logitech users: on Windows Logitech additionally supports to set the global Damper and Spring gain. Maybe it would be nicer to create a global gain for every supported Linux FF effect? Thanks, Elias