From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B1FDC433F5 for ; Sat, 5 Feb 2022 02:19:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1378927AbiBECTT (ORCPT ); Fri, 4 Feb 2022 21:19:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39630 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1376373AbiBECTR (ORCPT ); Fri, 4 Feb 2022 21:19:17 -0500 Received: from mail-oo1-xc32.google.com (mail-oo1-xc32.google.com [IPv6:2607:f8b0:4864:20::c32]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9D70CC061346 for ; Fri, 4 Feb 2022 18:19:16 -0800 (PST) Received: by mail-oo1-xc32.google.com with SMTP id p4-20020a4a8e84000000b002e598a51d60so6771612ook.2 for ; Fri, 04 Feb 2022 18:19:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:in-reply-to:references:from:user-agent:date:message-id :subject:to:cc; bh=cwAvPdmH6i1eqh2dUujon6iMut8KAmem6g6qtz93bHg=; b=eDhXz2upav5A0sO+ukPvPUIGLlbSZKwXKI6rcj1G9cNWo8hk3Ux6tGIElvsVzn410s qZH4bruGvicuFk80Y86GYy8Yztk0syKklEGUgQ/vVhEQ4P9tzsGHrmxHDzHCl4egmc5N GQV9V/bYJcVoGnSVFSmR3zhkB4JrJVJkrIYvo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:in-reply-to:references:from :user-agent:date:message-id:subject:to:cc; bh=cwAvPdmH6i1eqh2dUujon6iMut8KAmem6g6qtz93bHg=; b=erXHneJhdo87xHpuRHkZJ+9FjKRj2IIFRVCbO2FsotTwWycAEUmos/jdTRG3rQqO0u 6/bzQAI8wmGkgXOWqsMXcQQtsbyDpWJ2y5TsOUZaiZAJN0+lkQ4A/ax65BjHF6QIBLvv wkHjQKowVJvO1yPlc237G9biGNXhWAw6Rhd36H4zIZQmtZgctqhlhy4UstvNs8COk2mr KBQ62zSYhd+KXZ9Z0mCIO8bkDZ6rqd5cbE2oi9r/Hi446/rjWAQrkU/dwDS/0xikk2B5 cyX00oV0C6q66dMBe/Ux5wFVxbehDZcTqxGi8u0EPqKULoqPG/d8KyNnqdiS7VUITUxi s+0A== X-Gm-Message-State: AOAM530xfc5xeXGWSwG0vd8vlzBkzUAYbRenTmLNyFFT008onYKz7H/x 08n17HpOdIlqThGEPBblcEW+6nyZloFbnKTm7zN6aA== X-Google-Smtp-Source: ABdhPJx0s9TlZNnm+o8py20JIb6f4e7uTGOQYfrnUwMZnsyDa/bhriTxwJEUszfVCOqfvKTrhz6N0cjGITCoxPbYbwk= X-Received: by 2002:a05:6870:6256:: with SMTP id r22mr484173oak.8.1644027556039; Fri, 04 Feb 2022 18:19:16 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sat, 5 Feb 2022 02:19:15 +0000 MIME-Version: 1.0 In-Reply-To: <202202050807.BvUyitVE-lkp@intel.com> References: <20220204202021.895426-4-swboyd@chromium.org> <202202050807.BvUyitVE-lkp@intel.com> From: Stephen Boyd User-Agent: alot/0.10 Date: Sat, 5 Feb 2022 02:19:15 +0000 Message-ID: Subject: Re: [PATCH 3/5] HID: Extract vivaldi hid feature mapping for use in hid-hammer To: Dmitry Torokhov , Jiri Kosina , benjamin.tissoires@redhat.com, kernel test robot Cc: kbuild-all@lists.01.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, "Sean O'Brien" , Douglas Anderson , Zhengqiao Xia Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Quoting kernel test robot (2022-02-04 16:15:59) > Hi Stephen, > > I love your patch! Yet something to improve: > > [auto build test ERROR on 26291c54e111ff6ba87a164d85d4a4e134b7315c] > > url: https://github.com/0day-ci/linux/commits/Stephen-Boyd/Input-HID-Consolidate-ChromeOS-Vivaldi-keyboard-logic/20220205-042211 > base: 26291c54e111ff6ba87a164d85d4a4e134b7315c > config: x86_64-randconfig-a004-20220131 (https://download.01.org/0day-ci/archive/20220205/202202050807.BvUyitVE-lkp@intel.com/config) > compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 > reproduce (this is a W=1 build): > # https://github.com/0day-ci/linux/commit/83759eb892fd16fd0bb7ff4bb0c4baa4e7a0283e > git remote add linux-review https://github.com/0day-ci/linux > git fetch --no-tags linux-review Stephen-Boyd/Input-HID-Consolidate-ChromeOS-Vivaldi-keyboard-logic/20220205-042211 > git checkout 83759eb892fd16fd0bb7ff4bb0c4baa4e7a0283e > # save the config file to linux build tree > mkdir build_dir > make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot > > All errors (new ones prefixed by >>): > > vmlinux.o: warning: objtool: mce_start()+0x4e: call to clear_bit() leaves .noinstr.text section > vmlinux.o: warning: objtool: mce_read_aux()+0x41: call to mca_msr_reg() leaves .noinstr.text section > vmlinux.o: warning: objtool: do_machine_check()+0x39d: call to test_bit() leaves .noinstr.text section > vmlinux.o: warning: objtool: enter_from_user_mode()+0x4e: call to on_thread_stack() leaves .noinstr.text section > vmlinux.o: warning: objtool: syscall_enter_from_user_mode()+0x53: call to on_thread_stack() leaves .noinstr.text section > vmlinux.o: warning: objtool: syscall_enter_from_user_mode_prepare()+0x4e: call to on_thread_stack() leaves .noinstr.text section > vmlinux.o: warning: objtool: irqentry_enter_from_user_mode()+0x4e: call to on_thread_stack() leaves .noinstr.text section > ld: drivers/input/vivaldi-keymap.o: in function `vivaldi_hid_feature_mapping': > >> drivers/input/vivaldi-keymap.c:73: undefined reference to `hid_alloc_report_buf' > >> ld: drivers/input/vivaldi-keymap.c:90: undefined reference to `hid_hw_raw_request' > >> ld: drivers/input/vivaldi-keymap.c:108: undefined reference to `hid_report_raw_event' > Ah I see. CONFIG_HID=m but CONFIG_VIVALDIFMAP=y so we need to make the whole file into a module when CONFIG_HID is a module, but then that means the atkbd driver would need to be a module too. Probably best to move this hid part to yet another file in drivers/hid/ to keep things tidy.