From: "Tomasz Pakuła" <tomasz.pakula.oficjalny@gmail.com>
To: Jiri Kosina <jikos@kernel.org>
Cc: bentiss@kernel.org, anssi.hannula@gmail.com, oleg@makarenk.ooo,
linux-input@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH 2/3] HID: pidff: Make sure to fetch pool before checking SIMULTANEOUS_MAX
Date: Mon, 10 Feb 2025 10:57:13 +0100 [thread overview]
Message-ID: <CAFqprmwgTRC7OOaRbcHNKL-AcReeSVPnjP=g=2XQwSmU+7Jd=Q@mail.gmail.com> (raw)
In-Reply-To: <773ns28r-189s-9s5o-71q3-3286s376866r@xreary.bet>
On Mon, 10 Feb 2025 at 09:52, Jiri Kosina <jikos@kernel.org> wrote:
> On Sat, 8 Feb 2025, Tomasz Pakuła wrote:
> > + /* Try 20 times if PID_SIMULTANEOUS_MAX < 2.
> > + We must make sure this isn't just an error */
>
> Sorry for annoying nit: this is not really consistent with Kernel / HID
> comment style :)
>
> --
> Jiri Kosina
> SUSE Labs
No problem! I must say I did think this might seem janky as simple two-line
comment didn't feel right when it took up 4 lines, but on the other hand, this
looks just a bit out of place as well.
I'll send out an improved v2 today.
Thanks, Tomasz
P.S.
Thank you for merging this. I worried we'd have to wait for Anssi to leave
his comments/reviews as he told me recently he's quite busy and doesn't
have much time to go over all this PID work but he appreciates the CCs.
next prev parent reply other threads:[~2025-02-10 9:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-08 17:36 [PATCH 0/3] HID: pidff: Compatibility update and new devices Tomasz Pakuła
2025-02-08 17:36 ` [PATCH 1/3] MAINTAINERS: Update hid-universal-pidff entry Tomasz Pakuła
2025-02-08 17:36 ` [PATCH 2/3] HID: pidff: Make sure to fetch pool before checking SIMULTANEOUS_MAX Tomasz Pakuła
2025-02-10 8:52 ` Jiri Kosina
2025-02-10 9:57 ` Tomasz Pakuła [this message]
2025-02-08 17:36 ` [PATCH 3/3] HID: hid-universal-pidff: Add Asetek wheelbases support Tomasz Pakuła
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFqprmwgTRC7OOaRbcHNKL-AcReeSVPnjP=g=2XQwSmU+7Jd=Q@mail.gmail.com' \
--to=tomasz.pakula.oficjalny@gmail.com \
--cc=anssi.hannula@gmail.com \
--cc=bentiss@kernel.org \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=oleg@makarenk.ooo \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).