From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="DE1M362M" Received: from mail-lf1-x12c.google.com (mail-lf1-x12c.google.com [IPv6:2a00:1450:4864:20::12c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B051C1B1 for ; Tue, 5 Dec 2023 18:55:58 -0800 (PST) Received: by mail-lf1-x12c.google.com with SMTP id 2adb3069b0e04-50bf898c43cso2908558e87.1 for ; Tue, 05 Dec 2023 18:55:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1701831356; x=1702436156; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=kAjB+OSC2G0sATXrxYuI8k53/GEiZUhN5YxDKMU/l7c=; b=DE1M362Mr3J/o1u4oHby3q8T9PzICCGMhNDiPxByQf26C+O8nh+Ac0/iEtSpdkOHdK npS7G+QzxOjRmZJc0xTj6esaIRFMbt429pOLjuowICKmitmWx6K2WZayTLw7uA2VKbB+ 7OhrbyrAUf9ARrYLCWK+Hnw5xPz9s9W4Hv7Og= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701831356; x=1702436156; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kAjB+OSC2G0sATXrxYuI8k53/GEiZUhN5YxDKMU/l7c=; b=p7EFnoa9nAsWGQoy35t4qobStwVRinuK84RE/RM4SLZTxhV/+PGwkJ5C2zjo6D9sUv chvm8x07PLmOGUcvg6BCY7cPJwnpdgb/VU3Eh8vWKHxcHTlQ0GaL5stYW+k/kVC+7XcB +wAeLcH0LPkYwpYm90vF74xQBNkZLHkewiOm3UqoELDiE+sdnFr//W4wFvPL099GYpkc VFay5uAFFZXIRhosVLiuzLyOSrOXBiJbv3R2pP0habmCqvqIy43uyOfEu81H4ku7S/OG x0CLcEKSwrQ00Swxioyqp3GYDgB5ydnEYVbjx+AOvpRQg/iOCAGBZ/MweR6Xup4Vnh0j 61kA== X-Gm-Message-State: AOJu0YzN/N2Xn8JH+XOEbLLhHMzrfHvwyxCYoB4sYBqwaovgWPePHrpU rbJRoDGcPATbu1YYLJXOTNDBi1+sO4m3HJEwyb9B/A== X-Google-Smtp-Source: AGHT+IHnNZLv+A8rBD2iJfouOzY8bodAfVe2SPHWkYOI3dEcOPciD4ew3LweH+XusZAZCM5WonigRoCXzwrqYp9fpWQ= X-Received: by 2002:a05:6512:1107:b0:50b:f88d:f83b with SMTP id l7-20020a056512110700b0050bf88df83bmr112272lfg.78.1701831355848; Tue, 05 Dec 2023 18:55:55 -0800 (PST) Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20231128084236.157152-1-wenst@chromium.org> <20231128084236.157152-5-wenst@chromium.org> <3700f05f-2411-4422-972f-f3df690efb84@collabora.com> In-Reply-To: <3700f05f-2411-4422-972f-f3df690efb84@collabora.com> From: Chen-Yu Tsai Date: Wed, 6 Dec 2023 10:55:44 +0800 Message-ID: Subject: Re: [RFC PATCH v3 4/5] arm64: dts: mediatek: mt8173-elm-hana: Mark touchscreens and trackpads as fail To: AngeloGioacchino Del Regno Cc: Doug Anderson , Rob Herring , Frank Rowand , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , Wolfram Sang , Benson Leung , Tzung-Bi Shih , chrome-platform@lists.linux.dev, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, Johan Hovold , Hsin-Yi Wang , Dmitry Torokhov , andriy.shevchenko@linux.intel.com, Jiri Kosina , linus.walleij@linaro.org, broonie@kernel.org, gregkh@linuxfoundation.org, hdegoede@redhat.com, james.clark@arm.com, james@equiv.tech, keescook@chromium.org, rafael@kernel.org, tglx@linutronix.de, Jeff LaBundy , linux-input@vger.kernel.org, linux-i2c@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Dec 5, 2023 at 6:22=E2=80=AFPM AngeloGioacchino Del Regno wrote: > > Il 04/12/23 17:50, Doug Anderson ha scritto: > > Hi, > > > > On Sun, Dec 3, 2023 at 10:59=E2=80=AFPM Chen-Yu Tsai wrote: > >> > >> On Sat, Dec 2, 2023 at 8:58=E2=80=AFAM Doug Anderson wrote: > >>> > >>> Hi, > >>> > >>> On Tue, Nov 28, 2023 at 12:45=E2=80=AFAM Chen-Yu Tsai wrote: > >>>> > >>>> @@ -44,6 +46,7 @@ trackpad2: trackpad@2c { > >>>> reg =3D <0x2c>; > >>>> hid-descr-addr =3D <0x0020>; > >>>> wakeup-source; > >>>> + status =3D "fail-needs-probe"; > >>> > >>> While doing this, you could also remove the hack where the trackpad > >>> IRQ pinctrl is listed under i2c4. > >> > >> Sure. I do think we can do away with it though. According to at least = one > >> schematic, the interrupt line has pull-ups on both sides of the voltag= e > >> shifter. > >> > >> BTW, The touchscreen doesn't have pinctrl entries. This has pull-ups o= n > >> both sides of the voltage shifter as well. > > > > I dunno if the convention is different on Mediatek boards, but at > > least on boards I've been involved with in the past we've always put > > pinctrl entries just to make things explicit. This meant that we > > didn't rely on the firmware/bootrom/defaults to leave pulls in any > > particular state. ...otherwise those external pull-ups could be > > fighting with internal pull-downs, right? > > > > MediaTek boards aren't special and there's no good reason for those to re= ly on > firmware/bootrom/defaults - so there is no good reason to avoid declaring= any > relevant pinctrl entry. I think this should be migrated to use the proper GPIO bindings: the GPIO_PULL_UP / GPIO_PULL_DOWN / GPIO_BIAS_DISABLE flags. But that's a different discussion. ChenYu