From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chen-Yu Tsai Subject: Re: [PATCH 0/2] use correct values for startup time bits for AXP22X/AXP8XX PEKs Date: Tue, 18 Jul 2017 15:40:27 +0800 Message-ID: References: <20170717095307.15986-1-quentin.schulz@free-electrons.com> <20170718071847.bkujmrmna72wqwb7@dell> <1f2d37bd-b4a1-2653-c1c6-6dced95b814a@free-electrons.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: Received: from smtp.csie.ntu.edu.tw ([140.112.30.61]:42596 "EHLO smtp.csie.ntu.edu.tw" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751189AbdGRHkw (ORCPT ); Tue, 18 Jul 2017 03:40:52 -0400 In-Reply-To: <1f2d37bd-b4a1-2653-c1c6-6dced95b814a@free-electrons.com> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Quentin Schulz Cc: Lee Jones , Dmitry Torokhov , Chen-Yu Tsai , Hans de Goede , "linux-input@vger.kernel.org" , linux-kernel , Thomas Petazzoni , Maxime Ripard On Tue, Jul 18, 2017 at 3:25 PM, Quentin Schulz wrote: > Hi Lee, > > On 18/07/2017 09:18, Lee Jones wrote: >> On Mon, 17 Jul 2017, Quentin Schulz wrote: >> >>> Hi all, >>> >>> On 17/07/2017 11:53, Quentin Schulz wrote: >>>> According to their datasheets, the AXP221, AXP223, AXP288, AXP803, >>>> AXP809 and AXP813 PEK have different values for startup time bits from >>>> the AXP20X PEK (which are currently used for all the aforementioned PMICs). >>>> >>>> This patch series adds support for platform_device_id to axp20x-pek driver >>>> to support different startup time bits depending on PMIC's variant and set >>>> the correct platform_device_id in the mfd. >>>> >>>> This has been tested on AXP813. To perform the test, modify the value of >>>> startup and/or shutdown of the pek in sysfs. Press the button soldered to >>>> PEK input of the AXP the amount of time you set in sysfs. The PMIC shuts >>>> down the board without needing to unplug any power supply. Press PEK button >>>> the amount of time you set in sysfs for startup and the PMIC will start the >>>> board. Note that the time bits are obivoulsy hardware reset to their >>>> default when you unplug all power supplies from the board. >>>> >>> >>> I forgot to add that it depends on this patch series (particularly the >>> third patch (3/6) "mfd: axp20x: Add support for AXP813 PMIC") from >>> Chen-Yu: >>> https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1428284.html >> >> So you are going to re-send? >> > > You put your acked-by just yesterday on this patch. Do I need to resend > it anyway? > > The link I provided seems to be really slow/not working today, so I give > you another one for reference: https://patchwork.kernel.org/patch/9803439/ Or rather, would you like me to merge the AXP813 changes into my next version, and you resend the rest for faster separate inclusion? ChenYu > Thanks, > Quentin > >>>> Quentin Schulz (2): >>>> Input: axp20x-pek: add support for AXP221 PEK >>>> mfd: axp20x: use correct platform device id for many PEK >>>> >>>> drivers/input/misc/axp20x-pek.c | 62 ++++++++++++++++++++++++++++++++++------- >>>> drivers/mfd/axp20x.c | 12 ++++---- >>>> 2 files changed, 58 insertions(+), 16 deletions(-) >>>> >>> >> > > -- > Quentin Schulz, Free Electrons > Embedded Linux and Kernel engineering > http://free-electrons.com