From: Chris Bagwell <chris@cnpbagwell.com>
To: Przemo Firszt <przemo@firszt.eu>
Cc: aris@redhat.com, jkosina@suse.cz, pinglinux@gmail.com,
linuxwacom-devel@lists.sourceforge.net,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] HID: wacom: fix proximity tool release
Date: Tue, 21 Feb 2012 07:25:39 -0600 [thread overview]
Message-ID: <CAGzDe_bDK1LyRttGrKim++NRDCYVdWK=O3fGYabpvqXP5=stRA@mail.gmail.com> (raw)
In-Reply-To: <1329682829-24347-1-git-send-email-przemo@firszt.eu>
Reviewed-by: Chris Bagwell <chris@cnpbagwell.com>
On Sun, Feb 19, 2012 at 2:20 PM, Przemo Firszt <przemo@firszt.eu> wrote:
> Don't zero the current tool before reporting its release to the input
> subsystem.
>
> Signed-off-by: Aristeu Rozanski <aris@redhat.com>
> Tested-by: Przemo Firszt <przemo@firszt.eu>
> ---
> drivers/hid/hid-wacom.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/hid/hid-wacom.c b/drivers/hid/hid-wacom.c
> index 0621047..696b907 100644
> --- a/drivers/hid/hid-wacom.c
> +++ b/drivers/hid/hid-wacom.c
> @@ -322,10 +322,10 @@ static void wacom_i4_parse_pen_report(struct wacom_data *wdata,
>
> switch (data[1]) {
> case 0x80: /* Out of proximity report */
> - wdata->tool = 0;
> input_report_key(input, BTN_TOUCH, 0);
> input_report_abs(input, ABS_PRESSURE, 0);
> input_report_key(input, wdata->tool, 0);
> + wdata->tool = 0;
> input_sync(input);
> break;
> case 0xC2: /* Tool report */
> --
> 1.7.6.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-input" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2012-02-21 13:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-19 20:20 [PATCH] HID: wacom: fix proximity tool release Przemo Firszt
2012-02-21 13:25 ` Chris Bagwell [this message]
2012-02-21 13:25 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGzDe_bDK1LyRttGrKim++NRDCYVdWK=O3fGYabpvqXP5=stRA@mail.gmail.com' \
--to=chris@cnpbagwell.com \
--cc=aris@redhat.com \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxwacom-devel@lists.sourceforge.net \
--cc=pinglinux@gmail.com \
--cc=przemo@firszt.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).