* [PATCH] HID: wacom: fix proximity tool release
@ 2012-02-19 20:20 Przemo Firszt
2012-02-21 13:25 ` Chris Bagwell
2012-02-21 13:25 ` Jiri Kosina
0 siblings, 2 replies; 3+ messages in thread
From: Przemo Firszt @ 2012-02-19 20:20 UTC (permalink / raw)
To: aris, jkosina
Cc: pinglinux, linuxwacom-devel, linux-input, linux-kernel,
Przemo Firszt
Don't zero the current tool before reporting its release to the input
subsystem.
Signed-off-by: Aristeu Rozanski <aris@redhat.com>
Tested-by: Przemo Firszt <przemo@firszt.eu>
---
drivers/hid/hid-wacom.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/hid/hid-wacom.c b/drivers/hid/hid-wacom.c
index 0621047..696b907 100644
--- a/drivers/hid/hid-wacom.c
+++ b/drivers/hid/hid-wacom.c
@@ -322,10 +322,10 @@ static void wacom_i4_parse_pen_report(struct wacom_data *wdata,
switch (data[1]) {
case 0x80: /* Out of proximity report */
- wdata->tool = 0;
input_report_key(input, BTN_TOUCH, 0);
input_report_abs(input, ABS_PRESSURE, 0);
input_report_key(input, wdata->tool, 0);
+ wdata->tool = 0;
input_sync(input);
break;
case 0xC2: /* Tool report */
--
1.7.6.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] HID: wacom: fix proximity tool release
2012-02-19 20:20 [PATCH] HID: wacom: fix proximity tool release Przemo Firszt
@ 2012-02-21 13:25 ` Chris Bagwell
2012-02-21 13:25 ` Jiri Kosina
1 sibling, 0 replies; 3+ messages in thread
From: Chris Bagwell @ 2012-02-21 13:25 UTC (permalink / raw)
To: Przemo Firszt
Cc: aris, jkosina, pinglinux, linuxwacom-devel, linux-input,
linux-kernel
Reviewed-by: Chris Bagwell <chris@cnpbagwell.com>
On Sun, Feb 19, 2012 at 2:20 PM, Przemo Firszt <przemo@firszt.eu> wrote:
> Don't zero the current tool before reporting its release to the input
> subsystem.
>
> Signed-off-by: Aristeu Rozanski <aris@redhat.com>
> Tested-by: Przemo Firszt <przemo@firszt.eu>
> ---
> drivers/hid/hid-wacom.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/hid/hid-wacom.c b/drivers/hid/hid-wacom.c
> index 0621047..696b907 100644
> --- a/drivers/hid/hid-wacom.c
> +++ b/drivers/hid/hid-wacom.c
> @@ -322,10 +322,10 @@ static void wacom_i4_parse_pen_report(struct wacom_data *wdata,
>
> switch (data[1]) {
> case 0x80: /* Out of proximity report */
> - wdata->tool = 0;
> input_report_key(input, BTN_TOUCH, 0);
> input_report_abs(input, ABS_PRESSURE, 0);
> input_report_key(input, wdata->tool, 0);
> + wdata->tool = 0;
> input_sync(input);
> break;
> case 0xC2: /* Tool report */
> --
> 1.7.6.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-input" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] HID: wacom: fix proximity tool release
2012-02-19 20:20 [PATCH] HID: wacom: fix proximity tool release Przemo Firszt
2012-02-21 13:25 ` Chris Bagwell
@ 2012-02-21 13:25 ` Jiri Kosina
1 sibling, 0 replies; 3+ messages in thread
From: Jiri Kosina @ 2012-02-21 13:25 UTC (permalink / raw)
To: Przemo Firszt
Cc: aris, pinglinux, linuxwacom-devel, linux-input, linux-kernel
On Sun, 19 Feb 2012, Przemo Firszt wrote:
> Don't zero the current tool before reporting its release to the input
> subsystem.
>
> Signed-off-by: Aristeu Rozanski <aris@redhat.com>
> Tested-by: Przemo Firszt <przemo@firszt.eu>
> ---
> drivers/hid/hid-wacom.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/hid/hid-wacom.c b/drivers/hid/hid-wacom.c
> index 0621047..696b907 100644
> --- a/drivers/hid/hid-wacom.c
> +++ b/drivers/hid/hid-wacom.c
> @@ -322,10 +322,10 @@ static void wacom_i4_parse_pen_report(struct wacom_data *wdata,
>
> switch (data[1]) {
> case 0x80: /* Out of proximity report */
> - wdata->tool = 0;
> input_report_key(input, BTN_TOUCH, 0);
> input_report_abs(input, ABS_PRESSURE, 0);
> input_report_key(input, wdata->tool, 0);
> + wdata->tool = 0;
> input_sync(input);
> break;
> case 0xC2: /* Tool report */
I have put this into my upstream-fixes branch. I think this should go into
3.3 still.
Thanks,
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-02-21 13:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-02-19 20:20 [PATCH] HID: wacom: fix proximity tool release Przemo Firszt
2012-02-21 13:25 ` Chris Bagwell
2012-02-21 13:25 ` Jiri Kosina
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).