From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: fengping yu <fengping.yu@mediatek.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
Olof Johansson <olof@lixom.net>,
Aisheng Dong <aisheng.dong@nxp.com>,
Anson Huang <Anson.Huang@nxp.com>,
Maxime Ripard <mripard@kernel.org>,
Leonard Crestez <leonard.crestez@nxp.com>,
Dinh Nguyen <dinguyen@kernel.org>,
Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>,
Valentin Schneider <valentin.schneider@arm.com>,
Arnd Bergmann <arnd@arndb.de>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Mark Brown <broonie@kernel.org>,
Thierry Reding <treding@nvidia.com>,
YueHaibing <yuehaibing@huawei.com>,
Stefan Agner <stefan@agner.cn>, Jacky Bai <ping.bai@nxp.com>,
Marco Felsch <m.felsch@pengutronix.de>,
linux-input <linux-input@vger.kernel.org>,
linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
devicetree <devicetree@vger.kernel.org>,
wsd_upstream@mediatek.com
Subject: Re: [PATCH V2 2/2] drivers: input: keyboard
Date: Fri, 10 Jan 2020 09:35:30 +0200 [thread overview]
Message-ID: <CAHp75VcELo3f5VYqGbgjgBzOZOj360+EPmRF5Oh3VqBAF8TeHw@mail.gmail.com> (raw)
In-Reply-To: <20200110013230.GS8314@dtor-ws>
On Fri, Jan 10, 2020 at 3:34 AM Dmitry Torokhov
<dmitry.torokhov@gmail.com> wrote:
> On Wed, Jan 08, 2020 at 02:29:23PM +0800, fengping yu wrote:
> > From: "fengping.yu" <fengping.yu@mediatek.com>
...
> > +static void kpd_get_keymap_state(void __iomem *kp_base, u16 state[])
> > +{
> > + state[0] = readw(kp_base + KP_MEM1);
> > + state[1] = readw(kp_base + KP_MEM2);
> > + state[2] = readw(kp_base + KP_MEM3);
> > + state[3] = readw(kp_base + KP_MEM4);
> > + state[4] = readw(kp_base + KP_MEM5);
>
> Please use memcpy_formio() here.
Actually it's not an equivalent and may have side effects.
I already told somewhere that we lack of
mem*_*io{32,16,8}() implementation.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-01-10 7:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-08 6:29 Resend [PATCH V2] dt-bindings:input:keyboard:add MediaTek keypad controller binding fengping yu
2020-01-08 6:38 ` Marco Felsch
[not found] ` <20200108062923.14684-3-fengping.yu@mediatek.com>
2020-01-08 7:11 ` [PATCH V2 2/2] drivers: input: keyboard Marco Felsch
2020-01-08 7:23 ` Marco Felsch
2020-01-08 11:22 ` Andy Shevchenko
[not found] ` <1578473162.12131.13.camel@mtksdaap41>
2020-01-08 11:26 ` Andy Shevchenko
2020-01-10 1:20 ` Dmitry Torokhov
2020-01-10 1:32 ` Dmitry Torokhov
2020-01-10 7:35 ` Andy Shevchenko [this message]
[not found] ` <20200108062923.14684-2-fengping.yu@mediatek.com>
2020-01-10 1:16 ` [PATCH V2 1/2] Documentation: devicetree: bindings: input Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75VcELo3f5VYqGbgjgBzOZOj360+EPmRF5Oh3VqBAF8TeHw@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=Anson.Huang@nxp.com \
--cc=aisheng.dong@nxp.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=dinguyen@kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=fengping.yu@mediatek.com \
--cc=leonard.crestez@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=m.felsch@pengutronix.de \
--cc=marcin.juszkiewicz@linaro.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=mripard@kernel.org \
--cc=olof@lixom.net \
--cc=ping.bai@nxp.com \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
--cc=stefan@agner.cn \
--cc=treding@nvidia.com \
--cc=valentin.schneider@arm.com \
--cc=will@kernel.org \
--cc=wsd_upstream@mediatek.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).