* [PATCH] platform/x86: touchscreen_dmi: Update Hi10 Air filter
@ 2019-06-12 12:40 Christian Oder
2019-06-12 12:55 ` Hans de Goede
0 siblings, 1 reply; 7+ messages in thread
From: Christian Oder @ 2019-06-12 12:40 UTC (permalink / raw)
Cc: Christian Oder, Hans de Goede, Darren Hart, Andy Shevchenko,
linux-input, platform-driver-x86, linux-kernel
Turns out the Hi10 Air is built by multiple companies so using Hampoo
as a filter is not enough to cover all variants.
This has been verified as working on the Hampoo and Morshow version.
Signed-off-by: Christian Oder <me@myself5.de>
---
drivers/platform/x86/touchscreen_dmi.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/platform/x86/touchscreen_dmi.c b/drivers/platform/x86/touchscreen_dmi.c
index b662cb2d7cd5..61e7c4987d0d 100644
--- a/drivers/platform/x86/touchscreen_dmi.c
+++ b/drivers/platform/x86/touchscreen_dmi.c
@@ -597,7 +597,8 @@ static const struct dmi_system_id touchscreen_dmi_table[] = {
/* Chuwi Hi10 Air */
.driver_data = (void *)&chuwi_hi10_air_data,
.matches = {
- DMI_MATCH(DMI_BOARD_VENDOR, "Hampoo"),
+ DMI_MATCH(DMI_SYS_VENDOR, "CHUWI INNOVATION AND TECHNOLOGY(SHENZHEN)CO.LTD"),
+ DMI_MATCH(DMI_BOARD_NAME, "Cherry Trail CR"),
DMI_MATCH(DMI_PRODUCT_SKU, "P1W6_C109D_B"),
},
},
--
2.21.0
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH] platform/x86: touchscreen_dmi: Update Hi10 Air filter
2019-06-12 12:40 [PATCH] platform/x86: touchscreen_dmi: Update Hi10 Air filter Christian Oder
@ 2019-06-12 12:55 ` Hans de Goede
2019-06-17 12:37 ` Andy Shevchenko
2019-06-29 13:20 ` Andy Shevchenko
0 siblings, 2 replies; 7+ messages in thread
From: Hans de Goede @ 2019-06-12 12:55 UTC (permalink / raw)
To: Christian Oder
Cc: Darren Hart, Andy Shevchenko, linux-input, platform-driver-x86,
linux-kernel
Hi,
On 12-06-19 14:40, Christian Oder wrote:
> Turns out the Hi10 Air is built by multiple companies so using Hampoo
> as a filter is not enough to cover all variants.
>
> This has been verified as working on the Hampoo and Morshow version.
>
> Signed-off-by: Christian Oder <me@myself5.de>
Patch looks good to me:
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Regards,
Hans
> ---
> drivers/platform/x86/touchscreen_dmi.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/touchscreen_dmi.c b/drivers/platform/x86/touchscreen_dmi.c
> index b662cb2d7cd5..61e7c4987d0d 100644
> --- a/drivers/platform/x86/touchscreen_dmi.c
> +++ b/drivers/platform/x86/touchscreen_dmi.c
> @@ -597,7 +597,8 @@ static const struct dmi_system_id touchscreen_dmi_table[] = {
> /* Chuwi Hi10 Air */
> .driver_data = (void *)&chuwi_hi10_air_data,
> .matches = {
> - DMI_MATCH(DMI_BOARD_VENDOR, "Hampoo"),
> + DMI_MATCH(DMI_SYS_VENDOR, "CHUWI INNOVATION AND TECHNOLOGY(SHENZHEN)CO.LTD"),
> + DMI_MATCH(DMI_BOARD_NAME, "Cherry Trail CR"),
> DMI_MATCH(DMI_PRODUCT_SKU, "P1W6_C109D_B"),
> },
> },
>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] platform/x86: touchscreen_dmi: Update Hi10 Air filter
2019-06-12 12:55 ` Hans de Goede
@ 2019-06-17 12:37 ` Andy Shevchenko
2019-06-17 12:38 ` Andy Shevchenko
2019-06-29 13:20 ` Andy Shevchenko
1 sibling, 1 reply; 7+ messages in thread
From: Andy Shevchenko @ 2019-06-17 12:37 UTC (permalink / raw)
To: Hans de Goede
Cc: Christian Oder, Darren Hart, Andy Shevchenko, linux-input,
Platform Driver, Linux Kernel Mailing List
On Wed, Jun 12, 2019 at 3:55 PM Hans de Goede <hdegoede@redhat.com> wrote:
>
> Hi,
>
> On 12-06-19 14:40, Christian Oder wrote:
> > Turns out the Hi10 Air is built by multiple companies so using Hampoo
> > as a filter is not enough to cover all variants.
> >
> > This has been verified as working on the Hampoo and Morshow version.
> >
> > Signed-off-by: Christian Oder <me@myself5.de>
>
> Patch looks good to me:
>
> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
By some reason patchwork doesn't have a trace of this.
>
> Regards,
>
> Hans
>
>
> > ---
> > drivers/platform/x86/touchscreen_dmi.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/platform/x86/touchscreen_dmi.c b/drivers/platform/x86/touchscreen_dmi.c
> > index b662cb2d7cd5..61e7c4987d0d 100644
> > --- a/drivers/platform/x86/touchscreen_dmi.c
> > +++ b/drivers/platform/x86/touchscreen_dmi.c
> > @@ -597,7 +597,8 @@ static const struct dmi_system_id touchscreen_dmi_table[] = {
> > /* Chuwi Hi10 Air */
> > .driver_data = (void *)&chuwi_hi10_air_data,
> > .matches = {
> > - DMI_MATCH(DMI_BOARD_VENDOR, "Hampoo"),
> > + DMI_MATCH(DMI_SYS_VENDOR, "CHUWI INNOVATION AND TECHNOLOGY(SHENZHEN)CO.LTD"),
> > + DMI_MATCH(DMI_BOARD_NAME, "Cherry Trail CR"),
> > DMI_MATCH(DMI_PRODUCT_SKU, "P1W6_C109D_B"),
> > },
> > },
> >
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] platform/x86: touchscreen_dmi: Update Hi10 Air filter
2019-06-17 12:37 ` Andy Shevchenko
@ 2019-06-17 12:38 ` Andy Shevchenko
2019-06-17 12:52 ` Hans de Goede
0 siblings, 1 reply; 7+ messages in thread
From: Andy Shevchenko @ 2019-06-17 12:38 UTC (permalink / raw)
To: Hans de Goede
Cc: Christian Oder, Darren Hart, Andy Shevchenko, linux-input,
Platform Driver, Linux Kernel Mailing List
On Mon, Jun 17, 2019 at 3:37 PM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
>
> On Wed, Jun 12, 2019 at 3:55 PM Hans de Goede <hdegoede@redhat.com> wrote:
> >
> > Hi,
> >
> > On 12-06-19 14:40, Christian Oder wrote:
> > > Turns out the Hi10 Air is built by multiple companies so using Hampoo
> > > as a filter is not enough to cover all variants.
> > >
> > > This has been verified as working on the Hampoo and Morshow version.
> > >
> > > Signed-off-by: Christian Oder <me@myself5.de>
> >
> > Patch looks good to me:
> >
> > Reviewed-by: Hans de Goede <hdegoede@redhat.com>
>
> By some reason patchwork doesn't have a trace of this.
I meant, Hans, your message, the patch itself is there.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] platform/x86: touchscreen_dmi: Update Hi10 Air filter
2019-06-17 12:38 ` Andy Shevchenko
@ 2019-06-17 12:52 ` Hans de Goede
2019-06-17 15:01 ` Andy Shevchenko
0 siblings, 1 reply; 7+ messages in thread
From: Hans de Goede @ 2019-06-17 12:52 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Christian Oder, Darren Hart, Andy Shevchenko, linux-input,
Platform Driver, Linux Kernel Mailing List
Hi,
On 17-06-19 14:38, Andy Shevchenko wrote:
> On Mon, Jun 17, 2019 at 3:37 PM Andy Shevchenko
> <andy.shevchenko@gmail.com> wrote:
>>
>> On Wed, Jun 12, 2019 at 3:55 PM Hans de Goede <hdegoede@redhat.com> wrote:
>>>
>>> Hi,
>>>
>>> On 12-06-19 14:40, Christian Oder wrote:
>>>> Turns out the Hi10 Air is built by multiple companies so using Hampoo
>>>> as a filter is not enough to cover all variants.
>>>>
>>>> This has been verified as working on the Hampoo and Morshow version.
>>>>
>>>> Signed-off-by: Christian Oder <me@myself5.de>
>>>
>>> Patch looks good to me:
>>>
>>> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
>>
>
>> By some reason patchwork doesn't have a trace of this.
>
> I meant, Hans, your message, the patch itself is there.
Weird, no idea why this is happening.
Regards,
Hans
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] platform/x86: touchscreen_dmi: Update Hi10 Air filter
2019-06-17 12:52 ` Hans de Goede
@ 2019-06-17 15:01 ` Andy Shevchenko
0 siblings, 0 replies; 7+ messages in thread
From: Andy Shevchenko @ 2019-06-17 15:01 UTC (permalink / raw)
To: Hans de Goede
Cc: Christian Oder, Darren Hart, Andy Shevchenko, linux-input,
Platform Driver, Linux Kernel Mailing List
On Mon, Jun 17, 2019 at 3:52 PM Hans de Goede <hdegoede@redhat.com> wrote:
> On 17-06-19 14:38, Andy Shevchenko wrote:
> > On Mon, Jun 17, 2019 at 3:37 PM Andy Shevchenko
> > <andy.shevchenko@gmail.com> wrote:
> >> By some reason patchwork doesn't have a trace of this.
> > I meant, Hans, your message, the patch itself is there.
>
> Weird, no idea why this is happening.
For sake of testing, can you bounce the first message you sent here?
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] platform/x86: touchscreen_dmi: Update Hi10 Air filter
2019-06-12 12:55 ` Hans de Goede
2019-06-17 12:37 ` Andy Shevchenko
@ 2019-06-29 13:20 ` Andy Shevchenko
1 sibling, 0 replies; 7+ messages in thread
From: Andy Shevchenko @ 2019-06-29 13:20 UTC (permalink / raw)
To: Hans de Goede
Cc: Christian Oder, Darren Hart, Andy Shevchenko, linux-input,
Platform Driver, Linux Kernel Mailing List
On Wed, Jun 12, 2019 at 3:55 PM Hans de Goede <hdegoede@redhat.com> wrote:
>
> Hi,
>
> On 12-06-19 14:40, Christian Oder wrote:
> > Turns out the Hi10 Air is built by multiple companies so using Hampoo
> > as a filter is not enough to cover all variants.
> >
> > This has been verified as working on the Hampoo and Morshow version.
> >
> > Signed-off-by: Christian Oder <me@myself5.de>
>
> Patch looks good to me:
>
> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
>
I have pushed it, though I forget about this issue, it went without
this tag, sorry.
> Regards,
>
> Hans
>
>
> > ---
> > drivers/platform/x86/touchscreen_dmi.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/platform/x86/touchscreen_dmi.c b/drivers/platform/x86/touchscreen_dmi.c
> > index b662cb2d7cd5..61e7c4987d0d 100644
> > --- a/drivers/platform/x86/touchscreen_dmi.c
> > +++ b/drivers/platform/x86/touchscreen_dmi.c
> > @@ -597,7 +597,8 @@ static const struct dmi_system_id touchscreen_dmi_table[] = {
> > /* Chuwi Hi10 Air */
> > .driver_data = (void *)&chuwi_hi10_air_data,
> > .matches = {
> > - DMI_MATCH(DMI_BOARD_VENDOR, "Hampoo"),
> > + DMI_MATCH(DMI_SYS_VENDOR, "CHUWI INNOVATION AND TECHNOLOGY(SHENZHEN)CO.LTD"),
> > + DMI_MATCH(DMI_BOARD_NAME, "Cherry Trail CR"),
> > DMI_MATCH(DMI_PRODUCT_SKU, "P1W6_C109D_B"),
> > },
> > },
> >
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2019-06-29 13:20 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-06-12 12:40 [PATCH] platform/x86: touchscreen_dmi: Update Hi10 Air filter Christian Oder
2019-06-12 12:55 ` Hans de Goede
2019-06-17 12:37 ` Andy Shevchenko
2019-06-17 12:38 ` Andy Shevchenko
2019-06-17 12:52 ` Hans de Goede
2019-06-17 15:01 ` Andy Shevchenko
2019-06-29 13:20 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).