From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input <linux-input@vger.kernel.org>
Subject: Re: [PATCH v2 1/2] Input: tsc2007 - convert to GPIO descriptors
Date: Sun, 14 Mar 2021 23:11:11 +0200 [thread overview]
Message-ID: <CAHp75VeSSjdLE3raxUKaX_mDro=bYLgSQKSu5bfETSs3kPburA@mail.gmail.com> (raw)
In-Reply-To: <YEak4dbMINWNf2rr@google.com>
On Tue, Mar 9, 2021 at 12:27 AM Dmitry Torokhov
<dmitry.torokhov@gmail.com> wrote:
> On Mon, Mar 08, 2021 at 11:55:07PM +0200, Andy Shevchenko wrote:
...
> > + ts->get_pendown_state = tsc2007_get_pendown_state_gpio;
>
> OK, I know what my concern was here. You are now assigning
> ts->get_pendown_state unconditionally, and with ts->gpiod being NULL it
> will always return false, whereas the old code would skip setting
> ts->get_pendown_state when GPIO is not available, and the driver would
> assume that on interrupt the pen is actually down.
Good catch!
I fixed this in v3 (left original conditional, if we want to drop the
warning, then we may do it in a separate change).
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2021-03-14 21:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-08 21:55 [PATCH v2 1/2] Input: tsc2007 - convert to GPIO descriptors Andy Shevchenko
2021-03-08 21:55 ` [PATCH v2 2/2] Input: tsc2007 - make use of device properties Andy Shevchenko
2021-03-08 22:27 ` [PATCH v2 1/2] Input: tsc2007 - convert to GPIO descriptors Dmitry Torokhov
2021-03-14 21:11 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75VeSSjdLE3raxUKaX_mDro=bYLgSQKSu5bfETSs3kPburA@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).