* [PATCH] Add touchscreen platform data for the Onda oBook 20 Plus tablet.
@ 2017-12-10 22:02 Nerijus Baliunas
2017-12-11 10:24 ` Hans de Goede
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Nerijus Baliunas @ 2017-12-10 22:02 UTC (permalink / raw)
To: Hans de Goede, linux-input, platform-driver-x86; +Cc: Nerijus Baliunas
Signed-off-by: Nerijus Baliūnas <nerijus@users.sourceforge.net>
---
drivers/platform/x86/silead_dmi.c | 25 +++++++++++++++++++++++++
1 file changed, 25 insertions(+)
diff --git a/drivers/platform/x86/silead_dmi.c b/drivers/platform/x86/silead_dmi.c
index 266535c2a72f..414293e8c448 100644
--- a/drivers/platform/x86/silead_dmi.c
+++ b/drivers/platform/x86/silead_dmi.c
@@ -171,6 +171,23 @@ static const struct silead_ts_dmi_data digma_citi_e200_data = {
.properties = digma_citi_e200_props,
};
+static const struct property_entry onda_obook_20_plus_props[] = {
+ PROPERTY_ENTRY_U32("touchscreen-size-x", 1728),
+ PROPERTY_ENTRY_U32("touchscreen-size-y", 1148),
+ PROPERTY_ENTRY_BOOL("touchscreen-inverted-x"),
+ PROPERTY_ENTRY_BOOL("touchscreen-inverted-y"),
+ PROPERTY_ENTRY_BOOL("touchscreen-swapped-x-y"),
+ PROPERTY_ENTRY_STRING("firmware-name", "gsl3676-onda-obook-20-plus.fw"),
+ PROPERTY_ENTRY_U32("silead,max-fingers", 10),
+ PROPERTY_ENTRY_BOOL("silead,home-button"),
+ { }
+};
+
+static const struct silead_ts_dmi_data onda_obook_20_plus_data = {
+ .acpi_name = "MSSL1680:00",
+ .properties = onda_obook_20_plus_props,
+};
+
static const struct dmi_system_id silead_ts_dmi_table[] = {
{
/* CUBE iwork8 Air */
@@ -271,6 +288,14 @@ static const struct dmi_system_id silead_ts_dmi_table[] = {
DMI_MATCH(DMI_BOARD_NAME, "Cherry Trail CR"),
},
},
+ {
+ /* Onda oBook 20 Plus */
+ .driver_data = (void *)&onda_obook_20_plus_data,
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "ONDA"),
+ DMI_MATCH(DMI_PRODUCT_NAME, "OBOOK 20 PLUS"),
+ },
+ },
{ },
};
--
2.14.3
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] Add touchscreen platform data for the Onda oBook 20 Plus tablet.
2017-12-10 22:02 [PATCH] Add touchscreen platform data for the Onda oBook 20 Plus tablet Nerijus Baliunas
@ 2017-12-11 10:24 ` Hans de Goede
2017-12-11 18:25 ` Gregor Riepl
2017-12-18 12:41 ` Andy Shevchenko
2 siblings, 0 replies; 5+ messages in thread
From: Hans de Goede @ 2017-12-11 10:24 UTC (permalink / raw)
To: Nerijus Baliunas, linux-input, platform-driver-x86
Hi,
On 10-12-17 23:02, Nerijus Baliunas wrote:
> Signed-off-by: Nerijus Baliūnas <nerijus@users.sourceforge.net>
Looks good to me:
Acked-by: Hans de Goede <hdegoede@redhat.com>
Regards,
Hans
> ---
> drivers/platform/x86/silead_dmi.c | 25 +++++++++++++++++++++++++
> 1 file changed, 25 insertions(+)
>
> diff --git a/drivers/platform/x86/silead_dmi.c b/drivers/platform/x86/silead_dmi.c
> index 266535c2a72f..414293e8c448 100644
> --- a/drivers/platform/x86/silead_dmi.c
> +++ b/drivers/platform/x86/silead_dmi.c
> @@ -171,6 +171,23 @@ static const struct silead_ts_dmi_data digma_citi_e200_data = {
> .properties = digma_citi_e200_props,
> };
>
> +static const struct property_entry onda_obook_20_plus_props[] = {
> + PROPERTY_ENTRY_U32("touchscreen-size-x", 1728),
> + PROPERTY_ENTRY_U32("touchscreen-size-y", 1148),
> + PROPERTY_ENTRY_BOOL("touchscreen-inverted-x"),
> + PROPERTY_ENTRY_BOOL("touchscreen-inverted-y"),
> + PROPERTY_ENTRY_BOOL("touchscreen-swapped-x-y"),
> + PROPERTY_ENTRY_STRING("firmware-name", "gsl3676-onda-obook-20-plus.fw"),
> + PROPERTY_ENTRY_U32("silead,max-fingers", 10),
> + PROPERTY_ENTRY_BOOL("silead,home-button"),
> + { }
> +};
> +
> +static const struct silead_ts_dmi_data onda_obook_20_plus_data = {
> + .acpi_name = "MSSL1680:00",
> + .properties = onda_obook_20_plus_props,
> +};
> +
> static const struct dmi_system_id silead_ts_dmi_table[] = {
> {
> /* CUBE iwork8 Air */
> @@ -271,6 +288,14 @@ static const struct dmi_system_id silead_ts_dmi_table[] = {
> DMI_MATCH(DMI_BOARD_NAME, "Cherry Trail CR"),
> },
> },
> + {
> + /* Onda oBook 20 Plus */
> + .driver_data = (void *)&onda_obook_20_plus_data,
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "ONDA"),
> + DMI_MATCH(DMI_PRODUCT_NAME, "OBOOK 20 PLUS"),
> + },
> + },
> { },
> };
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] Add touchscreen platform data for the Onda oBook 20 Plus tablet.
2017-12-10 22:02 [PATCH] Add touchscreen platform data for the Onda oBook 20 Plus tablet Nerijus Baliunas
2017-12-11 10:24 ` Hans de Goede
@ 2017-12-11 18:25 ` Gregor Riepl
2017-12-12 1:11 ` Nerijus Baliunas
2017-12-18 12:41 ` Andy Shevchenko
2 siblings, 1 reply; 5+ messages in thread
From: Gregor Riepl @ 2017-12-11 18:25 UTC (permalink / raw)
To: Nerijus Baliunas, Hans de Goede, linux-input, platform-driver-x86
Thanks!
> + PROPERTY_ENTRY_STRING("firmware-name", "gsl3676-onda-obook-20-plus.fw"),
Firmware for this is available here:
https://github.com/onitake/gsl-firmware/blob/master/firmware/linux/silead/gsl3676-onda-obook-20-plus.fw
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] Add touchscreen platform data for the Onda oBook 20 Plus tablet.
2017-12-10 22:02 [PATCH] Add touchscreen platform data for the Onda oBook 20 Plus tablet Nerijus Baliunas
2017-12-11 10:24 ` Hans de Goede
2017-12-11 18:25 ` Gregor Riepl
@ 2017-12-18 12:41 ` Andy Shevchenko
2 siblings, 0 replies; 5+ messages in thread
From: Andy Shevchenko @ 2017-12-18 12:41 UTC (permalink / raw)
To: Nerijus Baliunas; +Cc: Hans de Goede, linux-input, Platform Driver
On Mon, Dec 11, 2017 at 12:02 AM, Nerijus Baliunas
<nerijus@users.sourceforge.net> wrote:
> Signed-off-by: Nerijus Baliūnas <nerijus@users.sourceforge.net>
Applied to my review and testing queue with massaged title and written
commit message, thanks. Please, don't forget to do it yourself next
time, otherwise it will slow review and promoting.
> ---
> drivers/platform/x86/silead_dmi.c | 25 +++++++++++++++++++++++++
> 1 file changed, 25 insertions(+)
>
> diff --git a/drivers/platform/x86/silead_dmi.c b/drivers/platform/x86/silead_dmi.c
> index 266535c2a72f..414293e8c448 100644
> --- a/drivers/platform/x86/silead_dmi.c
> +++ b/drivers/platform/x86/silead_dmi.c
> @@ -171,6 +171,23 @@ static const struct silead_ts_dmi_data digma_citi_e200_data = {
> .properties = digma_citi_e200_props,
> };
>
> +static const struct property_entry onda_obook_20_plus_props[] = {
> + PROPERTY_ENTRY_U32("touchscreen-size-x", 1728),
> + PROPERTY_ENTRY_U32("touchscreen-size-y", 1148),
> + PROPERTY_ENTRY_BOOL("touchscreen-inverted-x"),
> + PROPERTY_ENTRY_BOOL("touchscreen-inverted-y"),
> + PROPERTY_ENTRY_BOOL("touchscreen-swapped-x-y"),
> + PROPERTY_ENTRY_STRING("firmware-name", "gsl3676-onda-obook-20-plus.fw"),
> + PROPERTY_ENTRY_U32("silead,max-fingers", 10),
> + PROPERTY_ENTRY_BOOL("silead,home-button"),
> + { }
> +};
> +
> +static const struct silead_ts_dmi_data onda_obook_20_plus_data = {
> + .acpi_name = "MSSL1680:00",
> + .properties = onda_obook_20_plus_props,
> +};
> +
> static const struct dmi_system_id silead_ts_dmi_table[] = {
> {
> /* CUBE iwork8 Air */
> @@ -271,6 +288,14 @@ static const struct dmi_system_id silead_ts_dmi_table[] = {
> DMI_MATCH(DMI_BOARD_NAME, "Cherry Trail CR"),
> },
> },
> + {
> + /* Onda oBook 20 Plus */
> + .driver_data = (void *)&onda_obook_20_plus_data,
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "ONDA"),
> + DMI_MATCH(DMI_PRODUCT_NAME, "OBOOK 20 PLUS"),
> + },
> + },
> { },
> };
>
> --
> 2.14.3
>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-12-18 12:41 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-12-10 22:02 [PATCH] Add touchscreen platform data for the Onda oBook 20 Plus tablet Nerijus Baliunas
2017-12-11 10:24 ` Hans de Goede
2017-12-11 18:25 ` Gregor Riepl
2017-12-12 1:11 ` Nerijus Baliunas
2017-12-18 12:41 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).