From: Tim Harvey <tharvey@gateworks.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Lee Jones <lee.jones@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Mark Brown <broonie@kernel.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-input@vger.kernel.org
Subject: Re: [RFC 2/4] mfd: add Gateworks System Controller core driver
Date: Wed, 28 Feb 2018 13:16:02 -0800 [thread overview]
Message-ID: <CAJ+vNU2aeFAKf6e7RashG50Gu5qb3mqGvJUEPprh4AjFGs+MLg@mail.gmail.com> (raw)
In-Reply-To: <20180228185302.GD1203@lunn.ch>
On Wed, Feb 28, 2018 at 10:53 AM, Andrew Lunn <andrew@lunn.ch> wrote:
>> + dev_err(&client->dev, ">> 0x%02x %d\n", reg, ret);
>> + return ret;
>> + }
>> + dev_dbg(&client->dev, ">> 0x%02x=0x%02x (%d)\n", reg, val, retry);
>> +
>> + return 0;
>
> Hi Tim
>
> There appears to be a few spaces vs tabs issues in this file.
>
> Andrew
>
Thanks. I'll run through checkpatch prior to v2.
Tim
next prev parent reply other threads:[~2018-02-28 21:16 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-28 1:21 [RFC 0/4] Add support for the Gateworks System Controller Tim Harvey
2018-02-28 1:21 ` [RFC 1/4] dt-bindings: mfd: Add Gateworks System Controller bindings Tim Harvey
2018-02-28 1:21 ` [RFC 2/4] mfd: add Gateworks System Controller core driver Tim Harvey
2018-02-28 2:00 ` Randy Dunlap
2018-02-28 21:14 ` Tim Harvey
2018-02-28 18:53 ` Andrew Lunn
2018-02-28 21:16 ` Tim Harvey [this message]
2018-02-28 1:21 ` [RFC 3/4] hwmon: add Gateworks System Controller support Tim Harvey
2018-02-28 2:05 ` Guenter Roeck
2018-02-28 21:44 ` Tim Harvey
2018-02-28 22:36 ` Guenter Roeck
2018-02-28 1:21 ` [RFC 4/4] input: misc: Add " Tim Harvey
2018-02-28 4:54 ` Dmitry Torokhov
2018-02-28 19:44 ` Tim Harvey
2018-02-28 14:44 ` [RFC 0/4] Add support for the Gateworks System Controller Andrew Lunn
2018-02-28 16:34 ` Tim Harvey
2018-02-28 16:56 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJ+vNU2aeFAKf6e7RashG50Gu5qb3mqGvJUEPprh4AjFGs+MLg@mail.gmail.com \
--to=tharvey@gateworks.com \
--cc=andrew@lunn.ch \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).