From: Marcus Overhagen <marcus.overhagen@gmail.com>
To: Anshul Garg <aksgarg1989@gmail.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linux-input <linux-input@vger.kernel.org>
Subject: Re: [PATCH] Input-polldev:Check poll_interval range while registering input device
Date: Fri, 17 Jul 2015 22:29:13 +0200 [thread overview]
Message-ID: <CAJBHPog=kN71PS+XMQf85MSkdLvknGdZECuyi3r0DD2FmHh4mQ@mail.gmail.com> (raw)
In-Reply-To: <1437069433-76366-1-git-send-email-aksgarg1989@gmail.com>
On Thu, Jul 16, 2015 at 7:57 PM, Anshul Garg <aksgarg1989@gmail.com> wrote:
> + if (dev->poll_interval > dev->poll_interval_max ||
> + dev->poll_interval < dev->poll_interval_min) {
> + pr_err("Poll interval Range incorrect\n");
> + return -EINVAL;
> + }
>
> if (!dev->poll_interval)
> dev->poll_interval = 500;
So priviously, if poll_interval was 0 you got a sane default of 500,
and now you get -EINVAL.
Is this really useful and correct, and nobody using it is passing 0?
regards
Marcus
next prev parent reply other threads:[~2015-07-17 20:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-16 17:57 [PATCH] Input-polldev:Check poll_interval range while registering input device Anshul Garg
2015-07-16 19:35 ` Dmitry Torokhov
2015-07-17 13:41 ` Anshul Garg
2015-07-17 21:29 ` Dmitry Torokhov
2015-07-17 20:29 ` Marcus Overhagen [this message]
-- strict thread matches above, loose matches on Subject: below --
2015-07-14 13:25 Anshul Garg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJBHPog=kN71PS+XMQf85MSkdLvknGdZECuyi3r0DD2FmHh4mQ@mail.gmail.com' \
--to=marcus.overhagen@gmail.com \
--cc=aksgarg1989@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).