From: Krzysztof Kozlowski <krzk@kernel.org>
To: Cai Huoqing <caihuoqing@baidu.com>
Cc: Michael Hennerich <michael.hennerich@analog.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linux-input@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Input: ad7879 - Make use of the helper function dev_err_probe()
Date: Thu, 16 Sep 2021 21:30:14 +0200 [thread overview]
Message-ID: <CAJKOXPc9FtV6Pe55mk-HBS77vYo=rWauPOF_LJw3RuTyKC+XyQ@mail.gmail.com> (raw)
In-Reply-To: <20210916153056.13674-1-caihuoqing@baidu.com>
On Thu, 16 Sept 2021 at 17:47, Cai Huoqing <caihuoqing@baidu.com> wrote:
>
> When possible use dev_err_probe help to properly deal with the
> PROBE_DEFER error, the benefit is that DEFER issue will be logged
> in the devices_deferred debugfs file.
> Using dev_err_probe() can reduce code size, and the error value
> gets printed.
>
> Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
> ---
> drivers/input/touchscreen/ad7879.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
Please do not send patches one by one but group them in a series.
The patches you sent were already sent before:
https://lore.kernel.org/lkml/20200827185829.30096-1-krzk@kernel.org/
If such conversion is still applicable (although I have doubts -
preferred is to remove dev_err entirely), then I can rebase my older
series.
Best regards,
Krzysztof
prev parent reply other threads:[~2021-09-16 19:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-16 15:30 [PATCH] Input: ad7879 - Make use of the helper function dev_err_probe() Cai Huoqing
2021-09-16 19:30 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJKOXPc9FtV6Pe55mk-HBS77vYo=rWauPOF_LJw3RuTyKC+XyQ@mail.gmail.com' \
--to=krzk@kernel.org \
--cc=caihuoqing@baidu.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.hennerich@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).