From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Beomho Seo <beomho.seo@samsung.com>
Cc: Lee Jones <lee.jones@linaro.org>,
Sebastian Reichel <sre@kernel.org>,
Jaewon Kim <jaewon02.kim@samsung.com>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-pm@vger.kernel.org, linux-input@vger.kernel.org,
Inki Dae <inki.dae@samsung.com>,
SangBae Lee <sangbae90.lee@samsung.com>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Chanwoo Choi <cw00.choi@samsung.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>
Subject: Re: [PATCH v7 2/5] power: max77843_charger: Add Max77843 charger device driver
Date: Mon, 9 Mar 2015 12:02:56 +0100 [thread overview]
Message-ID: <CAJKOXPcLoOp30j5ZwFv2_nT5B+nZOnV6utck5KDw3vt-tmWRew@mail.gmail.com> (raw)
In-Reply-To: <54FCEABE.9000007@samsung.com>
2015-03-09 1:35 GMT+01:00 Beomho Seo <beomho.seo@samsung.com>:
> On 03/08/2015 05:13 AM, Sebastian Reichel wrote:
>> On Mon, Mar 02, 2015 at 07:10:35PM +0900, Jaewon Kim wrote:
>>> From: Beomho Seo <beomho.seo@samsung.com>
>>>
>>> This patch adds device driver of max77843 charger. This driver provide
>>> initialize each charging mode(e.g. fast charge, top-off mode and constant
>>> charging mode so on.). Additionally, control charging paramters to use
>>> i2c interface.
>>>
>>> Cc: Sebastian Reichel <sre@kernel.org>
>>> Signed-off-by: Beomho Seo <beomho.seo@samsung.com>
>>
>> Reviewed-By: Sebastian Reichel <sre@kernel.org>
>>
>> I can't take it as is, since it depends on the private header file
>> of PATCHv1.
>>
>> -- Sebastian
>>
>
> This patch reviewed by Sebastian.
> Could you Please merge that your git tree ?
Hi,
... and again we are adding a new driver for very similar chipset to
already supported. I looked at spec and the charger's registers are
almost the same as for max77693. Their layout and addresses are the
same. I see some minor differences, probably the most important would
be different values current (fast-charge, top-off). But still 90% of
registers are the same... Do we really have to add new driver?
Best regards,
Krzysztof
next prev parent reply other threads:[~2015-03-09 11:02 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-02 10:10 [PATCH v7 0/5] Add new MFD driver for MAX77843 Jaewon Kim
[not found] ` <1425291038-18269-1-git-send-email-jaewon02.kim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2015-03-02 10:10 ` [PATCH v7 1/5] mfd: max77843: Add max77843 MFD driver core driver Jaewon Kim
2015-03-02 10:20 ` Lee Jones
2015-03-02 10:36 ` Jaewon Kim
2015-03-02 10:41 ` Lee Jones
2015-03-02 10:10 ` [PATCH v7 2/5] power: max77843_charger: Add Max77843 charger device driver Jaewon Kim
2015-03-07 20:13 ` Sebastian Reichel
2015-03-09 0:35 ` Beomho Seo
2015-03-09 11:02 ` Krzysztof Kozlowski [this message]
2015-03-09 11:46 ` Beomho Seo
2015-03-09 12:13 ` Krzysztof Kozlowski
2015-03-10 13:44 ` Beomho Seo
[not found] ` <54FEF541.6000305-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2015-03-24 8:01 ` Beomho Seo
2015-03-24 8:38 ` Krzysztof Kozlowski
2015-03-25 0:39 ` Beomho Seo
2015-03-26 7:16 ` Krzysztof Kozlowski
2015-03-26 13:25 ` Beomho Seo
2015-03-26 13:54 ` Lee Jones
2015-03-26 23:49 ` Beomho Seo
2015-03-27 7:57 ` Lee Jones
2015-03-27 8:45 ` Beomho Seo
2015-03-27 10:08 ` Lee Jones
2015-03-02 10:10 ` [PATCH v7 3/5] power: max77843_battery: Add Max77843 fuel gauge " Jaewon Kim
2015-03-07 20:14 ` Sebastian Reichel
2015-03-09 0:36 ` Beomho Seo
2015-03-09 10:01 ` Krzysztof Kozlowski
[not found] ` <CAJKOXPcLa8jGBS9r=iAbuco5+9=XcjsEFazFtAWinYUQDArkUQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-03-10 13:44 ` Beomho Seo
2015-03-24 8:02 ` Beomho Seo
2015-03-24 8:39 ` Krzysztof Kozlowski
2015-03-02 10:10 ` [PATCH v7 4/5] Input: add haptic drvier on max77843 Jaewon Kim
2015-03-02 17:32 ` Dmitry Torokhov
2015-03-03 1:35 ` Jaewon Kim
2015-03-04 22:47 ` Dmitry Torokhov
2015-03-07 20:21 ` Sebastian Reichel
2015-03-08 4:55 ` Dmitry Torokhov
2015-03-02 10:10 ` [PATCH v7 5/5] Documentation: Add device tree bindings document for max77843 Jaewon Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJKOXPcLoOp30j5ZwFv2_nT5B+nZOnV6utck5KDw3vt-tmWRew@mail.gmail.com \
--to=k.kozlowski@samsung.com \
--cc=beomho.seo@samsung.com \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=inki.dae@samsung.com \
--cc=jaewon02.kim@samsung.com \
--cc=lee.jones@linaro.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=sangbae90.lee@samsung.com \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).