From mboxrd@z Thu Jan 1 00:00:00 1970 From: Krzysztof Kozlowski Subject: Re: [PATCH 3/4] arm64: dts: exynos: make tm2 and tm2e independent from each other Date: Tue, 3 Jan 2017 12:01:19 +0200 Message-ID: References: <1483430237-26823-1-git-send-email-jcsing.lee@samsung.com> <1483430237-26823-4-git-send-email-jcsing.lee@samsung.com> <20170103095842.h3hl64amje4qv4ts@gangnam.samsung> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <20170103095842.h3hl64amje4qv4ts-8vUhnHFVuGn35fTxX1Dczw@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Andi Shyti Cc: Jaechul Lee , Dmitry Torokhov , Rob Herring , Mark Rutland , Catalin Marinas , Will Deacon , Kukjin Kim , Javier Martinez Canillas , Chanwoo Choi , beomho.seo-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org, galaxyra-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-input@vger.kernel.org On Tue, Jan 3, 2017 at 11:58 AM, Andi Shyti wrote: > Hi Krzysztof, > >> > Currently tm2e dts includes tm2 but there are some differences >> > between the two boards and tm2 has some properties that tm2e >> > doesn't have. >> > >> > That's why it's important to keep the two dts files independent >> > and put all the commonalities in a tm2-common.dtsi file. >> > >> > Signed-off-by: Andi Shyti >> > Signed-off-by: Jaechul Lee >> > --- >> > .../boot/dts/exynos/exynos5433-tm2-common.dtsi | 1046 ++++++++++++++++++++ >> > arch/arm64/boot/dts/exynos/exynos5433-tm2.dts | 1033 +------------------ >> > arch/arm64/boot/dts/exynos/exynos5433-tm2e.dts | 2 +- >> > 3 files changed, 1049 insertions(+), 1032 deletions(-) >> > create mode 100644 arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi >> >> I would like to see here the rename and diff from it. Not entire delta >> (deletions and addons). It is not possible to compare it... I think >> git supports it by default with similarity of 50%. > > I understand, it's indeed quite cryptic to understand. But all > the diff algorithms (patience, minimal, histogram, myers) give > the same result. I don't know how to make it better. > > I could split this patch, but this also means breaking tm2's > functionality, which looks worse. > > Please tell me if you know a better way for generating the patch. git format-patch -M95%? Krzysztof -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html