* behaviour change for keyboards introduced by "HID: generic: create one input report per application type"
@ 2020-04-01 20:02 Siarhei Vishniakou
2020-04-08 16:45 ` Siarhei Vishniakou
2020-05-12 5:22 ` Peter Hutterer
0 siblings, 2 replies; 6+ messages in thread
From: Siarhei Vishniakou @ 2020-04-01 20:02 UTC (permalink / raw)
To: Garfield Tan, linux-input, Benjamin Tissoires, Jiri Kosina
Hello linux-input,
We have noticed a recent behavior change introduced by the commit:
https://github.com/torvalds/linux/commit/f07b3c1da92db108662f99417a212fc1eddc44d1
HID: generic: create one input report per application type.
We have been looking into the behaviour of the Microsoft Designer
keyboard. Prior to these patches, the keyboard would report as a
single input_device to the user space. After these patches, the
keyboard is now split into 2 input devices: “Designer Keyboard
Consumer Control” and “"Designer Keyboard Keyboard". We noticed that
this behavior also applies to the keyboard Dell KB216. In the Dell
case, it is split into 3 devices, which include “Consumer Control”
(for some of the media keys) and “System Control” (for the sleep
button).
In both Microsoft and Dell cases, these are pretty standard keyboards,
although they do contain media keys and power/sleep keys.
Could you please confirm that this new behaviour is indeed
intentional, and that you wanted keyboards to be split in this
fashion?
Thanks,
Siarhei
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: behaviour change for keyboards introduced by "HID: generic: create one input report per application type"
2020-04-01 20:02 behaviour change for keyboards introduced by "HID: generic: create one input report per application type" Siarhei Vishniakou
@ 2020-04-08 16:45 ` Siarhei Vishniakou
2020-04-21 21:37 ` Siarhei Vishniakou
2020-05-12 5:22 ` Peter Hutterer
1 sibling, 1 reply; 6+ messages in thread
From: Siarhei Vishniakou @ 2020-04-08 16:45 UTC (permalink / raw)
To: Garfield Tan, linux-input, Benjamin Tissoires, Jiri Kosina
Hi Benjamin and Jiri,
Could you provide your thoughts on this?
On Wed, Apr 1, 2020 at 1:02 PM Siarhei Vishniakou <svv@google.com> wrote:
>
> Hello linux-input,
>
> We have noticed a recent behavior change introduced by the commit:
> https://github.com/torvalds/linux/commit/f07b3c1da92db108662f99417a212fc1eddc44d1
> HID: generic: create one input report per application type.
>
> We have been looking into the behaviour of the Microsoft Designer
> keyboard. Prior to these patches, the keyboard would report as a
> single input_device to the user space. After these patches, the
> keyboard is now split into 2 input devices: “Designer Keyboard
> Consumer Control” and “"Designer Keyboard Keyboard". We noticed that
> this behavior also applies to the keyboard Dell KB216. In the Dell
> case, it is split into 3 devices, which include “Consumer Control”
> (for some of the media keys) and “System Control” (for the sleep
> button).
>
> In both Microsoft and Dell cases, these are pretty standard keyboards,
> although they do contain media keys and power/sleep keys.
>
> Could you please confirm that this new behaviour is indeed
> intentional, and that you wanted keyboards to be split in this
> fashion?
>
> Thanks,
> Siarhei
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: behaviour change for keyboards introduced by "HID: generic: create one input report per application type"
2020-04-08 16:45 ` Siarhei Vishniakou
@ 2020-04-21 21:37 ` Siarhei Vishniakou
2020-05-11 18:09 ` Siarhei Vishniakou
0 siblings, 1 reply; 6+ messages in thread
From: Siarhei Vishniakou @ 2020-04-21 21:37 UTC (permalink / raw)
To: Garfield Tan, linux-input, Benjamin Tissoires, Jiri Kosina
Bringing this back.
Any thoughts on this Jiri and Benjamin?
On Wed, Apr 8, 2020 at 9:45 AM Siarhei Vishniakou <svv@google.com> wrote:
>
> Hi Benjamin and Jiri,
>
> Could you provide your thoughts on this?
>
> On Wed, Apr 1, 2020 at 1:02 PM Siarhei Vishniakou <svv@google.com> wrote:
> >
> > Hello linux-input,
> >
> > We have noticed a recent behavior change introduced by the commit:
> > https://github.com/torvalds/linux/commit/f07b3c1da92db108662f99417a212fc1eddc44d1
> > HID: generic: create one input report per application type.
> >
> > We have been looking into the behaviour of the Microsoft Designer
> > keyboard. Prior to these patches, the keyboard would report as a
> > single input_device to the user space. After these patches, the
> > keyboard is now split into 2 input devices: “Designer Keyboard
> > Consumer Control” and “"Designer Keyboard Keyboard". We noticed that
> > this behavior also applies to the keyboard Dell KB216. In the Dell
> > case, it is split into 3 devices, which include “Consumer Control”
> > (for some of the media keys) and “System Control” (for the sleep
> > button).
> >
> > In both Microsoft and Dell cases, these are pretty standard keyboards,
> > although they do contain media keys and power/sleep keys.
> >
> > Could you please confirm that this new behaviour is indeed
> > intentional, and that you wanted keyboards to be split in this
> > fashion?
> >
> > Thanks,
> > Siarhei
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: behaviour change for keyboards introduced by "HID: generic: create one input report per application type"
2020-04-21 21:37 ` Siarhei Vishniakou
@ 2020-05-11 18:09 ` Siarhei Vishniakou
0 siblings, 0 replies; 6+ messages in thread
From: Siarhei Vishniakou @ 2020-05-11 18:09 UTC (permalink / raw)
To: Garfield Tan, linux-input, Benjamin Tissoires, Jiri Kosina
Bumping this back up, it would be awesome to receive a response on this.
On Tue, Apr 21, 2020 at 2:37 PM Siarhei Vishniakou <svv@google.com> wrote:
>
> Bringing this back.
>
> Any thoughts on this Jiri and Benjamin?
>
> On Wed, Apr 8, 2020 at 9:45 AM Siarhei Vishniakou <svv@google.com> wrote:
> >
> > Hi Benjamin and Jiri,
> >
> > Could you provide your thoughts on this?
> >
> > On Wed, Apr 1, 2020 at 1:02 PM Siarhei Vishniakou <svv@google.com> wrote:
> > >
> > > Hello linux-input,
> > >
> > > We have noticed a recent behavior change introduced by the commit:
> > > https://github.com/torvalds/linux/commit/f07b3c1da92db108662f99417a212fc1eddc44d1
> > > HID: generic: create one input report per application type.
> > >
> > > We have been looking into the behaviour of the Microsoft Designer
> > > keyboard. Prior to these patches, the keyboard would report as a
> > > single input_device to the user space. After these patches, the
> > > keyboard is now split into 2 input devices: “Designer Keyboard
> > > Consumer Control” and “"Designer Keyboard Keyboard". We noticed that
> > > this behavior also applies to the keyboard Dell KB216. In the Dell
> > > case, it is split into 3 devices, which include “Consumer Control”
> > > (for some of the media keys) and “System Control” (for the sleep
> > > button).
> > >
> > > In both Microsoft and Dell cases, these are pretty standard keyboards,
> > > although they do contain media keys and power/sleep keys.
> > >
> > > Could you please confirm that this new behaviour is indeed
> > > intentional, and that you wanted keyboards to be split in this
> > > fashion?
> > >
> > > Thanks,
> > > Siarhei
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: behaviour change for keyboards introduced by "HID: generic: create one input report per application type"
2020-04-01 20:02 behaviour change for keyboards introduced by "HID: generic: create one input report per application type" Siarhei Vishniakou
2020-04-08 16:45 ` Siarhei Vishniakou
@ 2020-05-12 5:22 ` Peter Hutterer
2020-05-12 14:34 ` Siarhei Vishniakou
1 sibling, 1 reply; 6+ messages in thread
From: Peter Hutterer @ 2020-05-12 5:22 UTC (permalink / raw)
To: Siarhei Vishniakou
Cc: Garfield Tan, linux-input, Benjamin Tissoires, Jiri Kosina
Hi Siarhei,
On Wed, Apr 01, 2020 at 01:02:03PM -0700, Siarhei Vishniakou wrote:
> Hello linux-input,
>
> We have noticed a recent behavior change introduced by the commit:
> https://github.com/torvalds/linux/commit/f07b3c1da92db108662f99417a212fc1eddc44d1
> HID: generic: create one input report per application type.
>
> We have been looking into the behaviour of the Microsoft Designer
> keyboard. Prior to these patches, the keyboard would report as a
> single input_device to the user space. After these patches, the
> keyboard is now split into 2 input devices: “Designer Keyboard
> Consumer Control” and “"Designer Keyboard Keyboard". We noticed that
> this behavior also applies to the keyboard Dell KB216. In the Dell
> case, it is split into 3 devices, which include “Consumer Control”
> (for some of the media keys) and “System Control” (for the sleep
> button).
>
> In both Microsoft and Dell cases, these are pretty standard keyboards,
> although they do contain media keys and power/sleep keys.
>
> Could you please confirm that this new behaviour is indeed
> intentional, and that you wanted keyboards to be split in this
> fashion?
Is there an actual issue with the split though or just a cosmetic one? This
is pretty standard for many keyboards (and other devices) but it shouldn't
have any negative effect on functionality.
Cheers,
Peter
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: behaviour change for keyboards introduced by "HID: generic: create one input report per application type"
2020-05-12 5:22 ` Peter Hutterer
@ 2020-05-12 14:34 ` Siarhei Vishniakou
0 siblings, 0 replies; 6+ messages in thread
From: Siarhei Vishniakou @ 2020-05-12 14:34 UTC (permalink / raw)
To: Peter Hutterer; +Cc: Garfield Tan, linux-input, Benjamin Tissoires, Jiri Kosina
Hi Peter,
It's a bit of both. it seems unnatural to have a single physical
device represented by 2 devices in the system. It also seems not
efficient in terms of performance, because we are now allocating twice
the number of devices, which causes twice the configuration change
events on Android.
On Mon, May 11, 2020 at 10:22 PM Peter Hutterer
<peter.hutterer@who-t.net> wrote:
>
> Hi Siarhei,
>
> On Wed, Apr 01, 2020 at 01:02:03PM -0700, Siarhei Vishniakou wrote:
> > Hello linux-input,
> >
> > We have noticed a recent behavior change introduced by the commit:
> > https://github.com/torvalds/linux/commit/f07b3c1da92db108662f99417a212fc1eddc44d1
> > HID: generic: create one input report per application type.
> >
> > We have been looking into the behaviour of the Microsoft Designer
> > keyboard. Prior to these patches, the keyboard would report as a
> > single input_device to the user space. After these patches, the
> > keyboard is now split into 2 input devices: “Designer Keyboard
> > Consumer Control” and “"Designer Keyboard Keyboard". We noticed that
> > this behavior also applies to the keyboard Dell KB216. In the Dell
> > case, it is split into 3 devices, which include “Consumer Control”
> > (for some of the media keys) and “System Control” (for the sleep
> > button).
> >
> > In both Microsoft and Dell cases, these are pretty standard keyboards,
> > although they do contain media keys and power/sleep keys.
> >
> > Could you please confirm that this new behaviour is indeed
> > intentional, and that you wanted keyboards to be split in this
> > fashion?
>
> Is there an actual issue with the split though or just a cosmetic one? This
> is pretty standard for many keyboards (and other devices) but it shouldn't
> have any negative effect on functionality.
>
> Cheers,
> Peter
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-05-12 14:35 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-04-01 20:02 behaviour change for keyboards introduced by "HID: generic: create one input report per application type" Siarhei Vishniakou
2020-04-08 16:45 ` Siarhei Vishniakou
2020-04-21 21:37 ` Siarhei Vishniakou
2020-05-11 18:09 ` Siarhei Vishniakou
2020-05-12 5:22 ` Peter Hutterer
2020-05-12 14:34 ` Siarhei Vishniakou
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).