From: Lukas Bulwahn <lukas.bulwahn@gmail.com>
To: Allen Ballway <ballway@chromium.org>, linux-input@vger.kernel.org
Cc: Jiri Kosina <jkosina@suse.cz>, Jiri Kosina <jikos@kernel.org>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>,
Henrik Rydberg <rydberg@bitmath.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Dependency on non-existing config I2C_DMI_CORE in commit a2f416bf062a ("HID: multitouch: Add quirks for flipped axes")
Date: Mon, 30 Jan 2023 09:43:49 +0100 [thread overview]
Message-ID: <CAKXUXMycsUQ3aWbAHa6fnSwmQpTt9PhagY14_k2sKGC+vGiqGg@mail.gmail.com> (raw)
Dear Allen,
with commit a2f416bf062a ("HID: multitouch: Add quirks for flipped
axes"), you add code that is dependent on the CONFIG_I2C_DMI_CORE.
However, this config symbol has not been defined anywhere in the
kernel repository. Is this a mistake in your code and you intended to
refer to another config symbol? Is there another patch to come that
adds this config symbol? Or is this a config symbol that only exists
in some out-of-tree repository?
Something might be odd here, because this code is effectively dead now
with being dependent on a non-existing config symbol.
Best regards,
Lukas
next reply other threads:[~2023-01-30 8:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-30 8:43 Lukas Bulwahn [this message]
2023-01-31 14:43 ` Dependency on non-existing config I2C_DMI_CORE in commit a2f416bf062a ("HID: multitouch: Add quirks for flipped axes") Allen Ballway
2023-02-01 10:42 ` Benjamin Tissoires
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKXUXMycsUQ3aWbAHa6fnSwmQpTt9PhagY14_k2sKGC+vGiqGg@mail.gmail.com \
--to=lukas.bulwahn@gmail.com \
--cc=ballway@chromium.org \
--cc=benjamin.tissoires@redhat.com \
--cc=jikos@kernel.org \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rydberg@bitmath.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).