From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [PATCH] Input: cros_ec_keyb: Remove check before calling pm_wakeup_event. Date: Sun, 5 Aug 2018 23:16:54 -0700 Message-ID: References: <20180605224458.62692-1-ravisadineni@chromium.org> <20180803072628eucas1p26abe0cb121b974401759502f8807bb96~HTx4BGQjl1119311193eucas1p2U@eucas1p2.samsung.com> <20180806052949eucas1p2483800c02730febd03d4a661a25fa405~INH40XvCx2719627196eucas1p2X@eucas1p2.samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: <20180806052949eucas1p2483800c02730febd03d4a661a25fa405~INH40XvCx2719627196eucas1p2X@eucas1p2.samsung.com> Sender: linux-kernel-owner@vger.kernel.org To: Marek Szyprowski Cc: Ravi Chandra Sadineni , Ravi Chandra Sadineni , Todd Broch , lkml , "linux-input@vger.kernel.org" , linux-samsung-soc@vger.kernel.org List-Id: linux-input@vger.kernel.org On Sun, Aug 5, 2018 at 10:29 PM Marek Szyprowski wrote: > > Hi Ravi, > > On 2018-08-03 18:53, Ravi Chandra Sadineni wrote: > > Understood. I am trying to reproduce this issue locally. Wanted to > > know the version of the kernel so I can give a try. Marek, can you > > please confirm the kernel version. > > > > Yes, sorry for the missing context, I was in hurry writing the report and > I wanted to send it before leaving the office. I'm testing mainline on Snow > with exynos_defconfig. > > Suspend/resume is partially broken already with mainline, but if you disable > CPUfreq support, it works fine on Linux v4.17. > > I've posted CPUfreq related fixes here if you are interested: > https://patchwork.kernel.org/patch/10554607/ > https://patchwork.kernel.org/patch/10554603/ > > The issue with cros_ec_keyb patch appears first on Linux v4.18-rc1, which is > the first release with that patch. Marek, this patch should only be in -next, I do not believe I sent it to Linus just yet. If mainline is broken for you it can't be caused by this patch. > Linux -next from 20180803, which has a few > more patches for cros_ec_keyb suffers from the same issue. Just to confirm, if you revert only this patch from -next you get suspend/resume back? Thanks. -- Dmitry