From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Dinghao Liu <dinghao.liu@zju.edu.cn>,
"Rafael J. Wysocki" <rafael@kernel.org>
Cc: Kangjie Lu <kjlu@umn.edu>, Richard Fontana <rfontana@redhat.com>,
Allison Randal <allison@lohutok.net>,
Thomas Gleixner <tglx@linutronix.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Input: omap-keypad - fix runtime pm imbalance on error
Date: Wed, 20 May 2020 10:02:27 -0700 [thread overview]
Message-ID: <CAKdAkRTyVL0uV0dGxHoEgMyB9FP6b0m60CHy7C4QXeR5WTGAJw@mail.gmail.com> (raw)
In-Reply-To: <20200520133432.19738-1-dinghao.liu@zju.edu.cn>
Hi Dinghao,
On Wed, May 20, 2020 at 6:35 AM Dinghao Liu <dinghao.liu@zju.edu.cn> wrote:
>
> pm_runtime_get_sync() increments the runtime PM usage counter even
> the call returns an error code. Thus a pairing decrement is needed
> on the error handling path to keep the counter balanced.
This is a very surprising behavior and I wonder if this should be
fixed in the PM core (or the required cleanup steps need to be called
out in the function description). I also see that a few drivers that
handle this situation correctly (?) call pm_runtime_put_noidle()
instead of pm_runtime_put_sync() in the error path.
Rafael, do you have any guidance here?
Thanks.
--
Dmitry
next prev parent reply other threads:[~2020-05-20 17:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-20 13:34 [PATCH] Input: omap-keypad - fix runtime pm imbalance on error Dinghao Liu
2020-05-20 17:02 ` Dmitry Torokhov [this message]
2020-05-20 17:19 ` Rafael J. Wysocki
2020-05-21 5:19 ` dinghao.liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKdAkRTyVL0uV0dGxHoEgMyB9FP6b0m60CHy7C4QXeR5WTGAJw@mail.gmail.com \
--to=dmitry.torokhov@gmail.com \
--cc=allison@lohutok.net \
--cc=dinghao.liu@zju.edu.cn \
--cc=gregkh@linuxfoundation.org \
--cc=kjlu@umn.edu \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=rfontana@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).