From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Bresticker Subject: Re: [PATCH 1/2] Input: Add binding document for a generic ADC keypad Date: Sun, 29 Mar 2015 21:56:32 -0700 Message-ID: References: <1427503398-19682-1-git-send-email-abrestic@chromium.org> <20150329040053.GD36501@dtor-ws> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <20150329040053.GD36501@dtor-ws> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Dmitry Torokhov Cc: linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala List-Id: linux-input@vger.kernel.org On Sat, Mar 28, 2015 at 9:00 PM, Dmitry Torokhov wrote: > On Fri, Mar 27, 2015 at 05:43:17PM -0700, Andrew Bresticker wrote: >> Add a binding document for a generic ADC keypad. Buttons on an ADC >> keypad are connected in a resistor ladder to an ADC. The binding >> describes the mapping of ADC channel and voltage ranges to buttons. >> >> Signed-off-by: Andrew Bresticker >> Cc: Rob Herring >> Cc: Pawel Moll >> Cc: Mark Rutland >> Cc: Ian Campbell >> Cc: Kumar Gala >> --- >> .../devicetree/bindings/input/adc-keys.txt | 43 ++++++++++++++++++++++ >> 1 file changed, 43 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/input/adc-keys.txt >> >> diff --git a/Documentation/devicetree/bindings/input/adc-keys.txt b/Documentation/devicetree/bindings/input/adc-keys.txt >> new file mode 100644 >> index 0000000..c9a57de >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/input/adc-keys.txt >> @@ -0,0 +1,43 @@ >> +Generic ADC keypad >> +================== >> + >> +Required properties: >> + - compatible: "adc-keys" >> + - poll-interval: Polling interval time in ms. >> + - io-channels: List of IIO channels used by the keypad. >> + See ../iio/iio-bindings.txt for details. >> + >> +Optional properties: >> + - autorepeat: Enable auto-repeat. >> + >> +Each button on the ADC keypad is represented by a sub-node. >> + >> +Required sub-node properties: >> + - label: Descriptive name for the key. >> + - linux,code: Keycode to emit. >> + - channel: IIO channel (index into the 'io-channels' above) to which this >> + button is attached. >> + - min-voltage: Minimum voltage in uV when this key is pressed. >> + - max-voltage: Maximum voltage in uV when this key is pressed. >> + >> +Optional sub-node properties: >> + - linux,input-type: Event type this key generates. Defaults to 1 (EV_KEY) if >> + not specified. > > I'd rather we have it defined explicitly in the binding, i.e. make it a > required property? Sure, will do. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html