From: Carlo Caione <carlo@endlessm.com>
To: Jiri Kosina <jikos@kernel.org>
Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>,
Carlo Caione <carlo@caione.org>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
Linux Upstreaming Team <linux@endlessm.com>
Subject: Re: [PATCH v3] HID: asus: support backlight on USB keyboards
Date: Wed, 12 Apr 2017 22:13:55 +0200 [thread overview]
Message-ID: <CAL9uMOGfHPiHihFXAYvLU06Jcd9hRQwQve2b=XsLOzHavTBhOA@mail.gmail.com> (raw)
In-Reply-To: <alpine.LSU.2.20.1704122211390.28004@cbobk.fhfr.pm>
On Wed, Apr 12, 2017 at 10:12 PM, Jiri Kosina <jikos@kernel.org> wrote:
> On Wed, 12 Apr 2017, Carlo Caione wrote:
>
>> >> + ret = devm_led_classdev_register(&hdev->dev, &drvdata->kbd_backlight->cdev);
>> >> + if (ret < 0) {
>> >> + /* No need to have this still around */
>> >> + devm_kfree(&hdev->dev, drvdata->kbd_backlight);
>> >> + cancel_work_sync(&drvdata->kbd_backlight->work);
>> >
>> > Small nitpick, you don't need to call cancel_work_sync() here, nobody
>> > could have called a worker. But OTOH, it doesn't hurt.
>> >
>> > Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
>>
>> Thanks Benjamin. Who should pick this up?
>
> I am going to.
>
> I'll drop the cancel_work_sync() call while doing it, ok?
Sure, go for it.
Thank you,
--
Carlo Caione | +39.340.80.30.096 | Endless
next prev parent reply other threads:[~2017-04-12 20:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-06 10:18 [PATCH v3] HID: asus: support backlight on USB keyboards Carlo Caione
2017-04-10 6:39 ` Benjamin Tissoires
2017-04-12 8:50 ` Carlo Caione
2017-04-12 20:12 ` Jiri Kosina
2017-04-12 20:13 ` Carlo Caione [this message]
2017-04-12 20:32 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAL9uMOGfHPiHihFXAYvLU06Jcd9hRQwQve2b=XsLOzHavTBhOA@mail.gmail.com' \
--to=carlo@endlessm.com \
--cc=benjamin.tissoires@redhat.com \
--cc=carlo@caione.org \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@endlessm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).