From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Lutomirski Subject: Re: [PATCH v2 10/17] input/joystick/analog: Switch from rdtscl() to native_read_tsc() Date: Tue, 16 Jun 2015 16:09:06 -0700 Message-ID: References: <0c3efbd7b70f76c5dea1d6a9958566cd5fb4a4da.1434152603.git.luto@kernel.org> <20150616230357.GC17610@dtor-ws> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: Received: from mail-lb0-f173.google.com ([209.85.217.173]:34151 "EHLO mail-lb0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752507AbbFPXJ2 (ORCPT ); Tue, 16 Jun 2015 19:09:28 -0400 Received: by lbbti3 with SMTP id ti3so20496950lbb.1 for ; Tue, 16 Jun 2015 16:09:27 -0700 (PDT) In-Reply-To: <20150616230357.GC17610@dtor-ws> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Dmitry Torokhov Cc: Andy Lutomirski , X86 ML , Borislav Petkov , Peter Zijlstra , John Stultz , "linux-kernel@vger.kernel.org" , Len Brown , Huang Rui , Denys Vlasenko , "linux-input@vger.kernel.org" Is it okay for -tip to take this and the other one you just acked? Thanks, Andy On Tue, Jun 16, 2015 at 4:03 PM, Dmitry Torokhov wrote: > On Fri, Jun 12, 2015 at 04:44:50PM -0700, Andy Lutomirski wrote: >> This timing code is hideous, and this doesn't help. It gets rid of >> one of the last users of rdtscl, though. >> >> Cc: Dmitry Torokhov >> Cc: linux-input@vger.kernel.org >> Signed-off-by: Andy Lutomirski > > Acked-by: Dmitry Torokhov > >> --- >> drivers/input/joystick/analog.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/input/joystick/analog.c b/drivers/input/joystick/analog.c >> index 4284080e481d..f871b4f00056 100644 >> --- a/drivers/input/joystick/analog.c >> +++ b/drivers/input/joystick/analog.c >> @@ -143,7 +143,7 @@ struct analog_port { >> >> #include >> >> -#define GET_TIME(x) do { if (cpu_has_tsc) rdtscl(x); else x = get_time_pit(); } while (0) >> +#define GET_TIME(x) do { if (cpu_has_tsc) x = (unsigned int)native_read_tsc(); else x = get_time_pit(); } while (0) >> #define DELTA(x,y) (cpu_has_tsc ? ((y) - (x)) : ((x) - (y) + ((x) < (y) ? PIT_TICK_RATE / HZ : 0))) >> #define TIME_NAME (cpu_has_tsc?"TSC":"PIT") >> static unsigned int get_time_pit(void) >> @@ -160,7 +160,7 @@ static unsigned int get_time_pit(void) >> return count; >> } >> #elif defined(__x86_64__) >> -#define GET_TIME(x) rdtscl(x) >> +#define GET_TIME(x) do { x = (unsigned int)native_read_tsc(); } while (0) >> #define DELTA(x,y) ((y)-(x)) >> #define TIME_NAME "TSC" >> #elif defined(__alpha__) || defined(CONFIG_MN10300) || defined(CONFIG_ARM) || defined(CONFIG_ARM64) || defined(CONFIG_TILE) >> -- >> 2.4.2 >> > > -- > Dmitry -- Andy Lutomirski AMA Capital Management, LLC