From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Eremin-Solenikov Subject: Re: [PATCH 02/15] GPIO: port LoCoMo gpio support from old driver Date: Fri, 14 Nov 2014 16:48:12 +0400 Message-ID: References: <1414454528-24240-1-git-send-email-dbaryshkov@gmail.com> <1414454528-24240-3-git-send-email-dbaryshkov@gmail.com> <20141106060335.GR8509@sirena.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: Sender: linux-leds-owner@vger.kernel.org To: Linus Walleij Cc: Mark Brown , "linux-arm-kernel@lists.infradead.org" , "linux-gpio@vger.kernel.org" , Linux Input , "linux-leds@vger.kernel.org" , "linux-spi@vger.kernel.org" , "linux-fbdev@vger.kernel.org" , "alsa-devel@alsa-project.org" , Andrea Adami , Russell King , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Alexandre Courbot , Dmitry Torokhov , Bryan Wu , Richard Purdie , Samuel Ortiz , Lee Jones , Jingoo List-Id: linux-input@vger.kernel.org 2014-11-14 13:11 GMT+03:00 Linus Walleij : > On Tue, Nov 11, 2014 at 2:16 PM, Dmitry Eremin-Solenikov > wrote: > >> Just to better understand your suggestions: do you want me to convert >> to regmap only gpio driver or do you suggest to convert all LoCoMo drivers? > > Um... I was just thinking about this one usecase. I ended up converting all drivers. It allowed me to clean up several points in the driver. > > It's no big deal, the other review comments are more important. Fixed most of the comments. Last remaining issue is factoring out m62332 interface. >> That is doable, of course, but the amount of changes is overwhelming. >> Also I'm concerned about the performance impact from going through >> regmap layers. > > Is it on a critical path? The current locking isn't any less invasive > AFAICT. > > Yours, > Linus Walleij -- With best wishes Dmitry