From: Stuart <stuart.a.hayhurst@gmail.com>
To: Kees Bakker <kees@ijzerbout.nl>
Cc: Linux Input <linux-input@vger.kernel.org>
Subject: Re: [PATCH] HID: corsair-void: Add missing initializer
Date: Thu, 24 Oct 2024 02:51:18 +0100 [thread overview]
Message-ID: <CALTg27kQOjBkX+W4L+EntReUkRSiPKKB4jhoB05f1LGvTNgyFg@mail.gmail.com> (raw)
In-Reply-To: <20241020195717.CD7CC17525E@bout3.ijzerbout.nl>
Good catch, thanks
Are you aware of 'scripts/get_maintainer.pl'? It might tell you to CC
Jiri Kosina and Benjamin Tissoires, as they can actually apply this.
Stuart
On Sun, 20 Oct 2024 at 20:57, Kees Bakker <kees@ijzerbout.nl> wrote:
>
> This was detected by Coverity, CID 1600743
>
> Signed-off-by: Kees Bakker <kees@ijzerbout.nl>
> ---
> drivers/hid/hid-corsair-void.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hid/hid-corsair-void.c b/drivers/hid/hid-corsair-void.c
> index 6ece56b850fc..d1fd04264656 100644
> --- a/drivers/hid/hid-corsair-void.c
> +++ b/drivers/hid/hid-corsair-void.c
> @@ -553,7 +553,7 @@ static void corsair_void_battery_remove_work_handler(struct work_struct *work)
> static void corsair_void_battery_add_work_handler(struct work_struct *work)
> {
> struct corsair_void_drvdata *drvdata;
> - struct power_supply_config psy_cfg;
> + struct power_supply_config psy_cfg = {};
> struct power_supply *new_supply;
>
> drvdata = container_of(work, struct corsair_void_drvdata,
> --
> 2.47.0
>
next prev parent reply other threads:[~2024-10-24 1:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-20 19:47 [PATCH] HID: corsair-void: Add missing initializer Kees Bakker
2024-10-24 1:51 ` Stuart [this message]
2024-11-03 2:32 ` Stuart
2025-01-06 2:08 ` Stuart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALTg27kQOjBkX+W4L+EntReUkRSiPKKB4jhoB05f1LGvTNgyFg@mail.gmail.com \
--to=stuart.a.hayhurst@gmail.com \
--cc=kees@ijzerbout.nl \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).