linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] HID: corsair-void: Add missing initializer
@ 2024-10-20 19:47 Kees Bakker
  2024-10-24  1:51 ` Stuart
  0 siblings, 1 reply; 4+ messages in thread
From: Kees Bakker @ 2024-10-20 19:47 UTC (permalink / raw)
  To: Stuart Hayhurst; +Cc: Linux Input

This was detected by Coverity, CID 1600743

Signed-off-by: Kees Bakker <kees@ijzerbout.nl>
---
 drivers/hid/hid-corsair-void.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/hid/hid-corsair-void.c b/drivers/hid/hid-corsair-void.c
index 6ece56b850fc..d1fd04264656 100644
--- a/drivers/hid/hid-corsair-void.c
+++ b/drivers/hid/hid-corsair-void.c
@@ -553,7 +553,7 @@ static void corsair_void_battery_remove_work_handler(struct work_struct *work)
 static void corsair_void_battery_add_work_handler(struct work_struct *work)
 {
 	struct corsair_void_drvdata *drvdata;
-	struct power_supply_config psy_cfg;
+	struct power_supply_config psy_cfg = {};
 	struct power_supply *new_supply;
 
 	drvdata = container_of(work, struct corsair_void_drvdata,
-- 
2.47.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] HID: corsair-void: Add missing initializer
  2024-10-20 19:47 [PATCH] HID: corsair-void: Add missing initializer Kees Bakker
@ 2024-10-24  1:51 ` Stuart
  2024-11-03  2:32   ` Stuart
  0 siblings, 1 reply; 4+ messages in thread
From: Stuart @ 2024-10-24  1:51 UTC (permalink / raw)
  To: Kees Bakker; +Cc: Linux Input

Good catch, thanks

Are you aware of 'scripts/get_maintainer.pl'? It might tell you to CC
Jiri Kosina and Benjamin Tissoires, as they can actually apply this.

Stuart

On Sun, 20 Oct 2024 at 20:57, Kees Bakker <kees@ijzerbout.nl> wrote:
>
> This was detected by Coverity, CID 1600743
>
> Signed-off-by: Kees Bakker <kees@ijzerbout.nl>
> ---
>  drivers/hid/hid-corsair-void.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hid/hid-corsair-void.c b/drivers/hid/hid-corsair-void.c
> index 6ece56b850fc..d1fd04264656 100644
> --- a/drivers/hid/hid-corsair-void.c
> +++ b/drivers/hid/hid-corsair-void.c
> @@ -553,7 +553,7 @@ static void corsair_void_battery_remove_work_handler(struct work_struct *work)
>  static void corsair_void_battery_add_work_handler(struct work_struct *work)
>  {
>         struct corsair_void_drvdata *drvdata;
> -       struct power_supply_config psy_cfg;
> +       struct power_supply_config psy_cfg = {};
>         struct power_supply *new_supply;
>
>         drvdata = container_of(work, struct corsair_void_drvdata,
> --
> 2.47.0
>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] HID: corsair-void: Add missing initializer
  2024-10-24  1:51 ` Stuart
@ 2024-11-03  2:32   ` Stuart
  2025-01-06  2:08     ` Stuart
  0 siblings, 1 reply; 4+ messages in thread
From: Stuart @ 2024-11-03  2:32 UTC (permalink / raw)
  To: Kees Bakker; +Cc: Linux Input, Jiri Kosina, Benjamin Tissoires, LKML

Checked the script, CCed missing people

Stuart

On Thu, 24 Oct 2024 at 02:51, Stuart <stuart.a.hayhurst@gmail.com> wrote:
>
> Good catch, thanks
>
> Are you aware of 'scripts/get_maintainer.pl'? It might tell you to CC
> Jiri Kosina and Benjamin Tissoires, as they can actually apply this.
>
> Stuart
>
> On Sun, 20 Oct 2024 at 20:57, Kees Bakker <kees@ijzerbout.nl> wrote:
> >
> > This was detected by Coverity, CID 1600743
> >
> > Signed-off-by: Kees Bakker <kees@ijzerbout.nl>
> > ---
> >  drivers/hid/hid-corsair-void.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/hid/hid-corsair-void.c b/drivers/hid/hid-corsair-void.c
> > index 6ece56b850fc..d1fd04264656 100644
> > --- a/drivers/hid/hid-corsair-void.c
> > +++ b/drivers/hid/hid-corsair-void.c
> > @@ -553,7 +553,7 @@ static void corsair_void_battery_remove_work_handler(struct work_struct *work)
> >  static void corsair_void_battery_add_work_handler(struct work_struct *work)
> >  {
> >         struct corsair_void_drvdata *drvdata;
> > -       struct power_supply_config psy_cfg;
> > +       struct power_supply_config psy_cfg = {};
> >         struct power_supply *new_supply;
> >
> >         drvdata = container_of(work, struct corsair_void_drvdata,
> > --
> > 2.47.0
> >

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] HID: corsair-void: Add missing initializer
  2024-11-03  2:32   ` Stuart
@ 2025-01-06  2:08     ` Stuart
  0 siblings, 0 replies; 4+ messages in thread
From: Stuart @ 2025-01-06  2:08 UTC (permalink / raw)
  To: Jiri Kosina; +Cc: Linux Input, Benjamin Tissoires, LKML, Kees Bakker

Hi, just bumping this since it's been a few months, will it be picked
up for 6.13?

Thanks,
Stuart

On Sun, 3 Nov 2024 at 02:32, Stuart <stuart.a.hayhurst@gmail.com> wrote:
>
> Checked the script, CCed missing people
>
> Stuart
>
> On Thu, 24 Oct 2024 at 02:51, Stuart <stuart.a.hayhurst@gmail.com> wrote:
> >
> > Good catch, thanks
> >
> > Are you aware of 'scripts/get_maintainer.pl'? It might tell you to CC
> > Jiri Kosina and Benjamin Tissoires, as they can actually apply this.
> >
> > Stuart
> >
> > On Sun, 20 Oct 2024 at 20:57, Kees Bakker <kees@ijzerbout.nl> wrote:
> > >
> > > This was detected by Coverity, CID 1600743
> > >
> > > Signed-off-by: Kees Bakker <kees@ijzerbout.nl>
> > > ---
> > >  drivers/hid/hid-corsair-void.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/hid/hid-corsair-void.c b/drivers/hid/hid-corsair-void.c
> > > index 6ece56b850fc..d1fd04264656 100644
> > > --- a/drivers/hid/hid-corsair-void.c
> > > +++ b/drivers/hid/hid-corsair-void.c
> > > @@ -553,7 +553,7 @@ static void corsair_void_battery_remove_work_handler(struct work_struct *work)
> > >  static void corsair_void_battery_add_work_handler(struct work_struct *work)
> > >  {
> > >         struct corsair_void_drvdata *drvdata;
> > > -       struct power_supply_config psy_cfg;
> > > +       struct power_supply_config psy_cfg = {};
> > >         struct power_supply *new_supply;
> > >
> > >         drvdata = container_of(work, struct corsair_void_drvdata,
> > > --
> > > 2.47.0
> > >

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2025-01-06  2:08 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-20 19:47 [PATCH] HID: corsair-void: Add missing initializer Kees Bakker
2024-10-24  1:51 ` Stuart
2024-11-03  2:32   ` Stuart
2025-01-06  2:08     ` Stuart

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).