From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH 00/14] DT: Fix spelling of standard properties Date: Wed, 20 Apr 2016 18:58:21 -0500 Message-ID: References: <1461166339-11109-1-git-send-email-geert+renesas@glider.be> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: Received: from mail.kernel.org ([198.145.29.136]:44665 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751335AbcDTX6p (ORCPT ); Wed, 20 Apr 2016 19:58:45 -0400 In-Reply-To: <1461166339-11109-1-git-send-email-geert+renesas@glider.be> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Geert Uytterhoeven Cc: Dmitry Torokhov , Lee Jones , Zhou Wang , Tony Lindgren , Srinivas Kandagatla , Michael Ellerman , Vinod Koul , Mark Brown , Alexandre Belloni , Joe Perches , "devicetree@vger.kernel.org" , "linux-input@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-pci@vger.kernel.org" , linuxppc-dev , dmaengine@vger.kernel.org On Wed, Apr 20, 2016 at 10:32 AM, Geert Uytterhoeven wrote: > Hi all, > > This patch series fixes misspellings of various standard DT properties > in DT binding documentation, DTS files, and error messages. > While most of these are harmless, some of them may cause hard-to-debug > failures. > > Please apply where appropriate. I'll happily take the whole series if you like, though I've not reviewed it all yet. > > Thanks! > > P.S. I used the following to detect misspellings: > > words="(address|clock|cooling|dma|gpio|index|interrupt|mbox|msi|nvmem|phy|phys|power-domain|pwm|reset|size|sleep|sound-dai|thermal-sensor)" > > git grep -Ew "${words}s-names" > git grep -E "[^-]\<${words}-name\>[^-]" > git grep -Ew "#${words}s-cells" # false positive phys-cells > git grep -E "#${words}-cell\>[^-]" > > git grep -w adress-cells > git grep -Ew "interrupts-(map|parent)" > > How can we prevent adding more of these? > > One simple option is to add the offenders to scripts/spelling.txt. > Alternatively, we may want to do something smarter and more DT specific? At least for #*-cells, we should be able to check most in dtc. When we find common properties, we can check the node for the phandle has a cells property. That would also check that the property is in fact a phandle. For *-names, we might be able to do a generic check in dtc for the corresponding property being present when we find a -names property. Though I suspect we're not consistent enough when/where we use plural. Rob