From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 873F7C43470 for ; Tue, 11 May 2021 14:24:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6C5D4613CB for ; Tue, 11 May 2021 14:24:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231785AbhEKOZI (ORCPT ); Tue, 11 May 2021 10:25:08 -0400 Received: from mail.kernel.org ([198.145.29.99]:60488 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231773AbhEKOZH (ORCPT ); Tue, 11 May 2021 10:25:07 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 7BF676187E; Tue, 11 May 2021 14:24:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1620743040; bh=K5dIHfa4f6iByDzBZIlrjQRjF6/bEjxWK1nUAqzRpew=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=JwaonazL7mHtxi37clzYyAaTtim9WYGe0jNdHlIfH66KDgGwD7QSLjEbrzvQMGgxj cDxVGdxsCSttt8JIk8CkX28GzepNyrYgvBI1JuvlFOJaMgtQqfDezEAUokTzNj9Di/ AXk99SIB1YVQuMhT8u6c+PflBGCBBVOhpYgwe9cQWyML9PY1iJv974grpxFQf2Zlfk aUGvNVSxIAiuPtI40JwsNp54vhkyiWFA7kZoGWTVhKJA8n9Wz1XL4k007CFv87+k2k ie6Ts3jvb6fuJ96vpOt+4eetlT3LXFNfFHwPDzEMeFWHkETQEygR474DDgvL+Oc1l/ 9cZVdIGiRgynA== Received: by mail-ed1-f53.google.com with SMTP id v5so12032451edc.8; Tue, 11 May 2021 07:24:00 -0700 (PDT) X-Gm-Message-State: AOAM5336IfGGHK4WvHXBJwJ1DkR9FDCNaG8F6ys88Kmm2uB8QC8lGEBv 7Kemzwb5+bFmJnTumAKG56ABR7gqI57cF0v2Aw== X-Google-Smtp-Source: ABdhPJxvejkoMRuepYDfIZklCbkFbvR1TbNfZ2DNIhf0/HxlULmwCrdyYucaU8vfjuT695OoYvWsI5knsrz4cgRv3yU= X-Received: by 2002:a50:c446:: with SMTP id w6mr33152086edf.62.1620743038881; Tue, 11 May 2021 07:23:58 -0700 (PDT) MIME-Version: 1.0 References: <20210510204524.617390-1-robh@kernel.org> <2b09c4ed-758d-6eed-8fc1-39653d10e844@lucaceresoli.net> In-Reply-To: <2b09c4ed-758d-6eed-8fc1-39653d10e844@lucaceresoli.net> From: Rob Herring Date: Tue, 11 May 2021 09:23:44 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] dt-bindings: More removals of type references on common properties To: Luca Ceresoli Cc: devicetree@vger.kernel.org, "linux-kernel@vger.kernel.org" , Stephen Boyd , Olivier Moysan , Arnaud Pouliquen , Jonathan Cameron , Lars-Peter Clausen , Dmitry Torokhov , Bjorn Andersson , Georgi Djakov , "David S. Miller" , Jakub Kicinski , Sebastian Reichel , Orson Zhai , Baolin Wang , Chunyan Zhang , Liam Girdwood , Mark Brown , Fabrice Gasnier , Odelu Kukatla , Alex Elder , Shengjiu Wang , linux-clk , Linux-ALSA , "open list:IIO SUBSYSTEM AND DRIVERS" , linux-arm-kernel , Linux Input , "open list:THERMAL" , netdev Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org On Tue, May 11, 2021 at 9:09 AM Luca Ceresoli wrote: > > Hi Rob, > > On 11/05/21 15:44, Rob Herring wrote: > > On Tue, May 11, 2021 at 2:20 AM Luca Ceresoli wrote: > >> > >> Hi, > >> > >> On 10/05/21 22:45, Rob Herring wrote: > >>> Users of common properties shouldn't have a type definition as the > >>> common schemas already have one. A few new ones slipped in and > >>> *-names was missed in the last clean-up pass. Drop all the unnecessary > >>> type references in the tree. > >>> > >>> A meta-schema update to catch these is pending. > >>> > >>> Cc: Luca Ceresoli > >>> Cc: Stephen Boyd > >>> Cc: Olivier Moysan > >>> Cc: Arnaud Pouliquen > >>> Cc: Jonathan Cameron > >>> Cc: Lars-Peter Clausen > >>> Cc: Dmitry Torokhov > >>> Cc: Bjorn Andersson > >>> Cc: Georgi Djakov > >>> Cc: "David S. Miller" > >>> Cc: Jakub Kicinski > >>> Cc: Sebastian Reichel > >>> Cc: Orson Zhai > >>> Cc: Baolin Wang > >>> Cc: Chunyan Zhang > >>> Cc: Liam Girdwood > >>> Cc: Mark Brown > >>> Cc: Fabrice Gasnier > >>> Cc: Odelu Kukatla > >>> Cc: Alex Elder > >>> Cc: Shengjiu Wang > >>> Cc: linux-clk@vger.kernel.org > >>> Cc: alsa-devel@alsa-project.org > >>> Cc: linux-iio@vger.kernel.org > >>> Cc: linux-arm-kernel@lists.infradead.org > >>> Cc: linux-input@vger.kernel.org > >>> Cc: linux-pm@vger.kernel.org > >>> Cc: netdev@vger.kernel.org > >>> Signed-off-by: Rob Herring > >>> --- > >>> Documentation/devicetree/bindings/clock/idt,versaclock5.yaml | 2 -- > >>> .../devicetree/bindings/iio/adc/st,stm32-dfsdm-adc.yaml | 1 - > >>> Documentation/devicetree/bindings/input/input.yaml | 1 - > >>> Documentation/devicetree/bindings/interconnect/qcom,rpmh.yaml | 1 - > >>> Documentation/devicetree/bindings/net/qcom,ipa.yaml | 1 - > >>> .../devicetree/bindings/power/supply/sc2731-charger.yaml | 2 +- > >>> Documentation/devicetree/bindings/sound/fsl,rpmsg.yaml | 2 +- > >>> 7 files changed, 2 insertions(+), 8 deletions(-) > >>> > >>> diff --git a/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml b/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml > >>> index c268debe5b8d..28675b0b80f1 100644 > >>> --- a/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml > >>> +++ b/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml > >>> @@ -60,7 +60,6 @@ properties: > >>> maxItems: 2 > >>> > >>> idt,xtal-load-femtofarads: > >>> - $ref: /schemas/types.yaml#/definitions/uint32 > >>> minimum: 9000 > >>> maximum: 22760 > >>> description: Optional load capacitor for XTAL1 and XTAL2 > >>> @@ -84,7 +83,6 @@ patternProperties: > >>> enum: [ 1800000, 2500000, 3300000 ] > >>> idt,slew-percent: > >>> description: The Slew rate control for CMOS single-ended. > >>> - $ref: /schemas/types.yaml#/definitions/uint32 > >>> enum: [ 80, 85, 90, 100 ] > >> > >> Ok, but shouldn't "percent" be listed in > >> Documentation/devicetree/bindings/property-units.txt? > > > > It is in the schema already[1]. > > Sure, but having an incomplete file in the kernel is poorly useful, if > not misleading. What about any of these options: > > - add to property-units.txt the missing units > - delete property-units.txt from the kernel sources > - replace the entire content of property-units.txt with a link to the > schema file, stating it is the authoritative and complete source > > I would feel a lot better with any of these. I can prepare the patch too. Yes, we should remove it. I just hadn't gotten around to it. Note there is one reference to it in writing-bindings.rst. Rob