Re: [PATCH v2] Apply the quirk HID_QUIRK_ALWAYS_POLL to the Edifier QR30 (2d99:a101).

[The-Luga <lugathe2@gmail.com>]

> You might want to wait a couple of days before sending a v3 so other
> reviewers can get a chance to make comments.

Yes, I shall wait. I was just *too eager*.

> You should include the HID: tag in the subject--
> ...] HID: Apply...
>
> The patch should be sent
>
> To:  the HID subsystem maintainers
> bentiss@kernel.org
> jikos@kernel.org
>
> Cc:  at a minimum
> linux-input@vger.kernel.org
> linux-kernel@vger.kernel.org
>
> plus any of the others already part of this thread.

This is very helpful. Thank you!

I read the documentation, but I was really waiting for comments before
finally sending it, as I didn’t want to create noise with all the
iterations of the patch. I didn’t realize I should wait before making
a bigger final change.

> Vendor ID 0x2d99 belongs to Edifier International Limited not Jieli
> Can you change to USB_VENDOR_ID_EDIFIER instead and move to the
> alphabetically correct location?

Could you kindly tell me where this info is?
Searching the internet I only found this website with this info:
https://the-sz.com/products/usbid/index.php?v=0x2D99

I just checked the vendor from `lsusb`, and I was hesitant whether to
write Jieli or Edifier.
I also decided to write QR30 instead of Hal0. Should I add a comment
mentioning Jieli as I did with the device?

> One more thing about patch style: The Signed-off-by: line should go
> above the --- line, whereas the revision information goes below it (as
> it is here).  The second --- line isn't needed (but it doesn't hurt).
>
> Look at other patch submissions in the email archives to see more
> examples of the style.
>
> Alan Stern

This is also very helpful. I should have done it in the first place. Thank you!

> Thanks for the patch!
> Regards,
> Terry Junge

It's me who is *super thankful*. I learned how to do packet capture,
hexcode/table analysis, and even wrote a script to time out the RGB
lights when idle, show a simple brightness animation (increasing and
decreasing steps before coming back to the default) when changing
volume, and synchronize it with my keyboard. I have more functionality
here than with the vendor software on those supported OS's. All thanks
to everyone who helped me debug and showed me the tools needed to do
this.

And even invited me to write my first patch. I believe this process
should be repetitive, with new people coming and going. I’m grateful
for the support and patience.