Re: [PATCH v4 1/2] Input: enable i8042-level wakeup control

[Daniel Drake <dsd@laptop.org>]

Hi,

Sorry for the delay in replying to this - I took sime time off.


On Wed, Aug 17, 2011 at 8:03 AM, Dmitry Torokhov
<dmitry.torokhov@gmail.com> wrote:
> OK, so we have the following scenario:
>
> - we do not need to worry about SND and LED on OLPC;
>
> - we do not need to worry about releasing the key that was pressed
>  when we went to sleep because they system would not go to sleep while
>  there is a key pressed. So the code in input_dev_resume() won't
>  actually release any keys unless a key was held pressed and we forced
>  system to sleep somehow.
>
> - we need to make sure we do not loose key press (and following events)
>  when we are waking up.

Yes, that seems accurate, with one more addition:

- we need to make sure we do not loose mouse button press or mouse
movement (and following events) when we are waking up.

> Can atkbd driver stash away serio byte data (when not in command mode)
> and replay it when pm notifier signals us that resume process is done?

I'm having trouble understanding this suggestion or relating it to the
problems in question and the previous patches posted. Are you
suggesting stashing of data that is sent from the host  to the
keyboard, or from the keyboard to the host? How does this solve our
issues? What about the mouse?

How is it going to avoid the input-level issues?

Thanks,
Daniel
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html