* [PATCH -next] Input: olpc_apsp - remove redundant dev_err call in olpc_apsp_probe()
@ 2013-07-17 5:31 Wei Yongjun
2013-07-17 13:00 ` Daniel Drake
0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2013-07-17 5:31 UTC (permalink / raw)
To: dmitry.torokhov, grant.likely, rob.herring, dsd
Cc: yongjun_wei, linux-input, devicetree-discuss
From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
drivers/input/serio/olpc_apsp.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/input/serio/olpc_apsp.c b/drivers/input/serio/olpc_apsp.c
index 818aa46..c96e3bd 100644
--- a/drivers/input/serio/olpc_apsp.c
+++ b/drivers/input/serio/olpc_apsp.c
@@ -187,10 +187,8 @@ static int olpc_apsp_probe(struct platform_device *pdev)
return -ENOENT;
priv->base = devm_ioremap_resource(&pdev->dev, res);
- if (IS_ERR(priv->base)) {
- dev_err(&pdev->dev, "Failed to map WTM registers\n");
+ if (IS_ERR(priv->base))
return PTR_ERR(priv->base);
- }
priv->irq = platform_get_irq(pdev, 0);
if (priv->irq < 0)
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] Input: olpc_apsp - remove redundant dev_err call in olpc_apsp_probe()
2013-07-17 5:31 [PATCH -next] Input: olpc_apsp - remove redundant dev_err call in olpc_apsp_probe() Wei Yongjun
@ 2013-07-17 13:00 ` Daniel Drake
0 siblings, 0 replies; 2+ messages in thread
From: Daniel Drake @ 2013-07-17 13:00 UTC (permalink / raw)
To: Wei Yongjun
Cc: Dmitry Torokhov, Grant Likely, rob.herring, yongjun_wei,
linux-input, devicetree-discuss@lists.ozlabs.org
On Tue, Jul 16, 2013 at 11:31 PM, Wei Yongjun <weiyj.lk@gmail.com> wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Acked-by: Daniel Drake <dsd@laptop.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-07-17 13:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-07-17 5:31 [PATCH -next] Input: olpc_apsp - remove redundant dev_err call in olpc_apsp_probe() Wei Yongjun
2013-07-17 13:00 ` Daniel Drake
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).