Re: [PATCH resend] HID: apple: fix up the F6 key on the Omoton KB066 keyboard

[Alex Henrie <alexhenrie24@gmail.com>]

On Mon, Feb 17, 2025 at 3:02 AM Aditya Garg <gargaditya08@live.com> wrote:

> Can you to test the patch at the bottom of this message?

I tried it and the patch works. However, I don't think it is the right approach.

> Then see if Fn+F6 switches the media to function keys or not, and media keys work by default or not.

The main problem I have with this idea is that there is nothing to
indicate to the user that Fn+F6 switches between Fn modes. If the user
presses Fn+F6 trying to actually type F6, they will be very confused.

What all of this discussion tells me is that it's not possible to make
the Omoton KB066 work perfectly, and it's not worth our time to try.
I'm not even convinced anymore that my original patch was a good idea.
Since we know now that we can detect the Omoton reliably enough based
on its name and its PID, I suggest that we simply add "Bluetooth
Keyboard" to the non_apple_keyboards table, with a new flag to
indicate that the name must match exactly and a new field to indicate
that the PID must be 022c. Being in the table will effectively disable
the counterproductive Fn key handling because fnmode=2 is equivalent
to fnmode=0 on the Omoton.

I will send a new patch.

-Alex