From: Sasha Finkelstein <fnkl.kernel@gmail.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Hector Martin <marcan@marcan.st>, Sven Peter <sven@svenpeter.dev>,
Alyssa Rosenzweig <alyssa@rosenzweig.io>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Henrik Rydberg <rydberg@bitmath.org>,
asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
linux-input@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] dt-bindings: input: touchscreen: Add Z2 controller
Date: Wed, 27 Nov 2024 11:49:06 +0100 [thread overview]
Message-ID: <CAMT+MTR46HbUJWQOwG+MY8OffquekynUs_BRCbuAosLrmc+smQ@mail.gmail.com> (raw)
In-Reply-To: <zwdpx6c6qxm5674u2sea5sgwdd2fwim4waijb2qvixf62wrshb@yqs6zurtf7ic>
On Wed, 27 Nov 2024 at 09:47, Krzysztof Kozlowski <krzk@kernel.org> wrote:
> What is the meaning of these two last compatibles in the list? What are
> these devices?
Those are generic compatibles for everything that speaks the Z2 protocol
multitouch is used for everything, as this is currently enough for the driver,
while touchbar is for userspace, as touchscreens and touchbars
need different handling. This specific schema was suggested
on the previous version.
> > + label:
> > + maxItems: 1
>
> Why is this needed? I think it is not part of common touchscreen schema.
> Drop, devices do not need labels - node name and unit address identify
> it. If this is needed for something else, then come with generic
> property matching all touchscreens.
I want some sort of a property to contain a human readable (ish)
name of this device.
next prev parent reply other threads:[~2024-11-27 10:49 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-26 20:47 [PATCH 0/4] Driver for Apple Z2 touchscreens Sasha Finkelstein via B4 Relay
2024-11-26 20:47 ` [PATCH 1/4] dt-bindings: input: touchscreen: Add Z2 controller Sasha Finkelstein via B4 Relay
2024-11-27 8:46 ` Krzysztof Kozlowski
2024-11-27 10:33 ` Krzysztof Kozlowski
2024-11-27 10:49 ` Sasha Finkelstein [this message]
2024-11-27 11:23 ` Sasha Finkelstein
2024-11-27 12:03 ` Krzysztof Kozlowski
2024-11-26 20:48 ` [PATCH 2/4] input: apple_z2: Add a driver for Apple Z2 touchscreens Sasha Finkelstein via B4 Relay
2024-11-27 2:22 ` Dmitry Torokhov
2024-11-27 8:24 ` Sasha Finkelstein
2024-11-27 19:59 ` Dmitry Torokhov
2024-11-27 9:00 ` Krzysztof Kozlowski
2024-11-27 10:19 ` Sasha Finkelstein
2024-11-27 10:22 ` Dmitry Torokhov
2024-11-27 10:25 ` Krzysztof Kozlowski
2024-11-26 20:48 ` [PATCH 3/4] arm64: dts: apple: Add touchbar digitizer nodes Sasha Finkelstein via B4 Relay
2024-11-26 21:14 ` Janne Grunau
2024-11-27 8:55 ` Krzysztof Kozlowski
2024-11-27 10:31 ` Sasha Finkelstein
2024-11-27 10:34 ` Krzysztof Kozlowski
2024-11-26 20:48 ` [PATCH 4/4] MAINTAINERS: Add entries for Apple Z2 touchscreen driver Sasha Finkelstein via B4 Relay
2024-11-27 1:51 ` [PATCH 0/4] Driver for Apple Z2 touchscreens Dmitry Torokhov
2024-11-27 8:29 ` Sasha Finkelstein
2024-11-27 15:29 ` Hector Martin
2024-11-27 16:20 ` Hector Martin
2024-11-28 8:37 ` Janne Grunau
2024-11-27 10:27 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMT+MTR46HbUJWQOwG+MY8OffquekynUs_BRCbuAosLrmc+smQ@mail.gmail.com \
--to=fnkl.kernel@gmail.com \
--cc=alyssa@rosenzweig.io \
--cc=asahi@lists.linux.dev \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcan@marcan.st \
--cc=robh@kernel.org \
--cc=rydberg@bitmath.org \
--cc=sven@svenpeter.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).