linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Fredrik Hallenberg <megahallon@gmail.com>
To: David Herrmann <dh.herrmann@gmail.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Jiri Kosina <jkosina@suse.cz>,
	"open list:HID CORE LAYER" <linux-input@vger.kernel.org>
Subject: Re: [PATCH] Handle spurious backslash key repeats on some keyboards
Date: Fri, 12 Sep 2014 13:34:57 +0200	[thread overview]
Message-ID: <CAMsZVf-r6GvPOUEUye9wcLrT-g8SXkk5b3HKBDDTyHjAj38aKQ@mail.gmail.com> (raw)
In-Reply-To: <CANq1E4Qw3_0M7BCgDJTX0WGHU+CnFdnuASX0JfEK-Btkc=7Rsg@mail.gmail.com>

Is the country tag derived from the bCountryCode seen in the HID
device descriptor seen when doing "lsusb -v"?
If so it probably wont work as it says "0 (Not supported)" on my
keyboard and a few others I have tested.

On Fri, Sep 12, 2014 at 12:29 PM, David Herrmann <dh.herrmann@gmail.com> wrote:
> Hi
>
> On Thu, Sep 11, 2014 at 10:35 PM, Fredrik Hallenberg
> <megahallon@gmail.com> wrote:
>> Thanks I had no idea about the hwdb but I have tried it now, it works if I use
>>
>> KEYBOARD_KEY_70031=reserved
>
> Thanks for confirming!
>
>> on my nordic keyboard, but a US keyboard user would have to use
>> scancode 70032 instead. If you chose the wrong one the backslash key
>> will be disabled.
>>
>> I don't think this is good solution as long as there is no way to
>> detect which version is used with the hardware matcher string.
>
> Well, you can match on "country" tags. Currently, the device
> identifiers contain vendor+product+version+country information. I
> assume the "country" field is different between your keyboard and a
> keyboard that swaps the key reports.
>
>> However I suppose udev should make it possible to do some kind of
>> script that does something similar to my original patch, that is,
>> detects which of the two keys in actually used and disables the other
>> one.
>
> If you post your mod-alias line of your device (or better: all
> information you can gather about the device), I can push it into hwdb.
> It is up to Dmitry and Jiri to decide whether it makes sense to deal
> with it in the kernel.
>
> Thanks
> David

  reply	other threads:[~2014-09-12 11:34 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-10  9:56 [PATCH] Handle spurious backslash key repeats on some keyboards Fredrik Hallenberg
2014-09-09  9:40 ` Fredrik Hallenberg
2014-09-09  9:42   ` Jiri Kosina
2014-09-09 10:37     ` Fredrik Hallenberg
2014-09-10  8:26   ` Jiri Kosina
2014-09-10 10:09     ` David Herrmann
2014-09-10 11:13       ` Fredrik Hallenberg
2014-09-10 14:22         ` David Herrmann
2014-09-10 22:51           ` Dmitry Torokhov
2014-09-11  8:50             ` Fredrik Hallenberg
2014-09-11 12:41               ` David Herrmann
2014-09-11 20:35                 ` Fredrik Hallenberg
2014-09-12 10:29                   ` David Herrmann
2014-09-12 11:34                     ` Fredrik Hallenberg [this message]
2014-09-12 11:47                       ` David Herrmann
2014-09-12 17:36                         ` Fredrik Hallenberg
2014-12-19 16:28                           ` RH
2014-12-20 19:56                             ` Fredrik Hallenberg
2014-09-14 16:45 ` David Herrmann
2014-09-14 17:03   ` David Herrmann
2014-09-14 22:53   ` Fredrik Hallenberg
2014-09-15  8:29     ` Fredrik Hallenberg
2014-09-15 14:39   ` Benjamin Tissoires
2014-09-15 14:47     ` Benjamin Tissoires
2014-09-15 14:52       ` David Herrmann
2014-09-15 15:14         ` Benjamin Tissoires

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAMsZVf-r6GvPOUEUye9wcLrT-g8SXkk5b3HKBDDTyHjAj38aKQ@mail.gmail.com \
    --to=megahallon@gmail.com \
    --cc=dh.herrmann@gmail.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=jkosina@suse.cz \
    --cc=linux-input@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).