* [PATCH v1] Input: pf1550 - Remove "defined but unused" warning
@ 2025-12-10 21:11 Vaibhav Gupta
2025-12-13 9:38 ` Dmitry Torokhov
0 siblings, 1 reply; 3+ messages in thread
From: Vaibhav Gupta @ 2025-12-10 21:11 UTC (permalink / raw)
To: Samuel Kayode, Dmitry Torokhov
Cc: Vaibhav Gupta, imx, linux-input, linux-kernel
If 'CONFIG_PM_SLEEP' is not set, compiler throws warning for *suspend() and
*resume() function for this driver. Using new 'DEFINE_SIMPLE_DEV_PM_OPS'
fixes it.
Signed-off-by: Vaibhav Gupta <vaibhavgupta40@gmail.com>
---
drivers/input/misc/pf1550-onkey.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/misc/pf1550-onkey.c b/drivers/input/misc/pf1550-onkey.c
index 9be6377151cb..0d1b570bbe47 100644
--- a/drivers/input/misc/pf1550-onkey.c
+++ b/drivers/input/misc/pf1550-onkey.c
@@ -173,7 +173,7 @@ static int pf1550_onkey_resume(struct device *dev)
return 0;
}
-static SIMPLE_DEV_PM_OPS(pf1550_onkey_pm_ops, pf1550_onkey_suspend,
+static DEFINE_SIMPLE_DEV_PM_OPS(pf1550_onkey_pm_ops, pf1550_onkey_suspend,
pf1550_onkey_resume);
static const struct platform_device_id pf1550_onkey_id[] = {
--
2.51.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH v1] Input: pf1550 - Remove "defined but unused" warning
2025-12-10 21:11 [PATCH v1] Input: pf1550 - Remove "defined but unused" warning Vaibhav Gupta
@ 2025-12-13 9:38 ` Dmitry Torokhov
2025-12-15 9:21 ` Geert Uytterhoeven
0 siblings, 1 reply; 3+ messages in thread
From: Dmitry Torokhov @ 2025-12-13 9:38 UTC (permalink / raw)
To: Vaibhav Gupta; +Cc: Samuel Kayode, imx, linux-input, linux-kernel
On Wed, Dec 10, 2025 at 09:11:41PM +0000, Vaibhav Gupta wrote:
> If 'CONFIG_PM_SLEEP' is not set, compiler throws warning for *suspend() and
> *resume() function for this driver. Using new 'DEFINE_SIMPLE_DEV_PM_OPS'
> fixes it.
>
> Signed-off-by: Vaibhav Gupta <vaibhavgupta40@gmail.com>
Applied, thank you.
--
Dmitry
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v1] Input: pf1550 - Remove "defined but unused" warning
2025-12-13 9:38 ` Dmitry Torokhov
@ 2025-12-15 9:21 ` Geert Uytterhoeven
0 siblings, 0 replies; 3+ messages in thread
From: Geert Uytterhoeven @ 2025-12-15 9:21 UTC (permalink / raw)
To: Dmitry Torokhov
Cc: Vaibhav Gupta, Samuel Kayode, imx, linux-input, linux-kernel
Hi Dmitry,
On Sat, 13 Dec 2025 at 10:39, Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote:
> On Wed, Dec 10, 2025 at 09:11:41PM +0000, Vaibhav Gupta wrote:
> > If 'CONFIG_PM_SLEEP' is not set, compiler throws warning for *suspend() and
> > *resume() function for this driver. Using new 'DEFINE_SIMPLE_DEV_PM_OPS'
> > fixes it.
> >
> > Signed-off-by: Vaibhav Gupta <vaibhavgupta40@gmail.com>
>
> Applied, thank you.
FTR, Samual submitted a similar patch 6 weeks before, which did take
into account alignment of the continuation:
https://lore.kernel.org/all/20251028-pf1550-v1-1-c50fae56b9b1@gmail.com
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-12-15 9:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-12-10 21:11 [PATCH v1] Input: pf1550 - Remove "defined but unused" warning Vaibhav Gupta
2025-12-13 9:38 ` Dmitry Torokhov
2025-12-15 9:21 ` Geert Uytterhoeven
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).