From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Jiri Slaby <jslaby@suse.cz>
Cc: Jiri Slaby <jirislaby@gmail.com>,
jkosina@suse.cz, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH 1/1] HID: microsoft, fix invalid rdesc for 3k kbd
Date: Sun, 11 Nov 2012 17:35:05 +0100 [thread overview]
Message-ID: <CAMuHMdXvBwFsGzApwR9pTUd55-c5zu0Fu4wOt=MeRabNtjQOLQ@mail.gmail.com> (raw)
In-Reply-To: <5096EE29.8090304@suse.cz>
On Sun, Nov 4, 2012 at 11:37 PM, Jiri Slaby <jslaby@suse.cz> wrote:
> On 11/04/2012 10:06 PM, Geert Uytterhoeven wrote:
>> On Fri, Oct 19, 2012 at 1:28 PM, Jiri Slaby <jslaby@suse.cz> wrote:
>>> + if ((quirks & MS_RDESC_3K) && *rsize == 106 &&
>>> + !memcmp((char []){ 0x19, 0x00, 0x29, 0xff },
>>> + &rdesc[94], 4)) {
>>
>> Which version of gcc are you using?
>
> 4.7.1. But that indeed fails too if memcmp is a macro. This is of course
> not the case for x86, so that I didn't hit that. I will post a patch to
> change this to standard array accesses. (This looked prettier though.)
BTW, you also have to add
#include <linux/string.h>
as on some configs, I get
drivers/hid/hid-microsoft.c:50: error: ‘memcmp’ undeclared (first use
in this function)
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2012-11-11 16:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-19 11:28 [PATCH 1/1] HID: microsoft, fix invalid rdesc for 3k kbd Jiri Slaby
2012-10-22 9:00 ` Jiri Kosina
2012-11-04 21:06 ` Geert Uytterhoeven
2012-11-04 22:37 ` Jiri Slaby
2012-11-05 8:05 ` Geert Uytterhoeven
2012-11-11 16:35 ` Geert Uytterhoeven [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMuHMdXvBwFsGzApwR9pTUd55-c5zu0Fu4wOt=MeRabNtjQOLQ@mail.gmail.com' \
--to=geert@linux-m68k.org \
--cc=jirislaby@gmail.com \
--cc=jkosina@suse.cz \
--cc=jslaby@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).