From: Benjamin Tissoires <benjamin.tissoires@gmail.com>
To: Tolga Cakir <tolga@cevel.net>
Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>,
Derya <derya.kiran@yahoo.de>, Jiri Kosina <jkosina@suse.cz>,
Reyad Attiyat <reyad.attiyat@gmail.com>,
linux-input <linux-input@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 4/4] HID: microsoft: undefining ms_map_key_clear after usage
Date: Wed, 9 Apr 2014 16:42:21 -0400 [thread overview]
Message-ID: <CAN+gG=HFEcsVdmuf6o2GyfSmjWRansS02MVbXdjws7xVNp1QGw@mail.gmail.com> (raw)
In-Reply-To: <1396631237-11813-1-git-send-email-tolga@cevel.net>
On Fri, Apr 4, 2014 at 1:07 PM, Tolga Cakir <tolga@cevel.net> wrote:
> This is inspired by various other hid drivers.
>
> Signed-off-by: Tolga Cakir <tolga@cevel.net>
> ---
> drivers/hid/hid-microsoft.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/hid/hid-microsoft.c b/drivers/hid/hid-microsoft.c
> index 5674c0c..5281d2d 100644
> --- a/drivers/hid/hid-microsoft.c
> +++ b/drivers/hid/hid-microsoft.c
> @@ -211,6 +211,8 @@ static int ms_sidewinder_kb_quirk(struct hid_input *hi, struct hid_usage *usage,
> return 1;
> }
>
> +#undef ms_map_key_clear
> +
Not sure this is really needed. The macro is prefixed by ms_, so I
will simply let it there.
Cheers,
Benjamin
> static int ms_sidewinder_control(struct hid_device *hdev, __u8 setup)
> {
> struct ms_data *sc = hid_get_drvdata(hdev);
> --
> 1.9.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-input" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-04-09 20:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-04 17:07 [PATCH 4/4] HID: microsoft: undefining ms_map_key_clear after usage Tolga Cakir
2014-04-09 20:42 ` Benjamin Tissoires [this message]
2014-04-10 0:02 ` Tolga Cakir
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAN+gG=HFEcsVdmuf6o2GyfSmjWRansS02MVbXdjws7xVNp1QGw@mail.gmail.com' \
--to=benjamin.tissoires@gmail.com \
--cc=benjamin.tissoires@redhat.com \
--cc=derya.kiran@yahoo.de \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=reyad.attiyat@gmail.com \
--cc=tolga@cevel.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).