From: Haojian Zhuang <haojian.zhuang@gmail.com>
To: Chao Xie <chao.xie@marvell.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@vger.kernel.org, eric.y.miao@gmail.com,
linux-arm-kernel@lists.infradead.org, haojian.zhuang@marvell.com
Subject: Re: [PATCH V3 3/4] Input: pxa27x_keypad direct key may be low active
Date: Mon, 2 Apr 2012 17:38:01 +0800 [thread overview]
Message-ID: <CAN1soZzcW6Oy_vd3U_WYy9RNL1BLDfG+NpWKg1HUfQDD0eJAUQ@mail.gmail.com> (raw)
In-Reply-To: <1333246084-14110-3-git-send-email-chao.xie@marvell.com>
On Sun, Apr 1, 2012 at 10:08 AM, Chao Xie <chao.xie@marvell.com> wrote:
> KPDK_DK only indicates the pin level of direct key.
> So it is related to board, and low level may be active which
> indicates that a key is pressed.
>
> Signed-off-by: Chao Xie <chao.xie@marvell.com>
> ---
> arch/arm/plat-pxa/include/plat/pxa27x_keypad.h | 2 ++
> drivers/input/keyboard/pxa27x_keypad.c | 10 +++++++++-
> 2 files changed, 11 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/plat-pxa/include/plat/pxa27x_keypad.h b/arch/arm/plat-pxa/include/plat/pxa27x_keypad.h
> index abcc36e..7ffb16b 100644
> --- a/arch/arm/plat-pxa/include/plat/pxa27x_keypad.h
> +++ b/arch/arm/plat-pxa/include/plat/pxa27x_keypad.h
> @@ -44,6 +44,8 @@ struct pxa27x_keypad_platform_data {
> /* direct keys */
> int direct_key_num;
> unsigned int direct_key_map[MAX_DIRECT_KEY_NUM];
> + /* the key output may be low active */
> + int direct_key_low_active;
>
> /* rotary encoders 0 */
> int enable_rotary0;
> diff --git a/drivers/input/keyboard/pxa27x_keypad.c b/drivers/input/keyboard/pxa27x_keypad.c
> index 5d71720..a60f14e 100644
> --- a/drivers/input/keyboard/pxa27x_keypad.c
> +++ b/drivers/input/keyboard/pxa27x_keypad.c
> @@ -311,7 +311,15 @@ static void pxa27x_keypad_scan_direct(struct pxa27x_keypad *keypad)
> if (pdata->enable_rotary0 || pdata->enable_rotary1)
> pxa27x_keypad_scan_rotary(keypad);
>
> - new_state = KPDK_DK(kpdk) & keypad->direct_key_mask;
> + /*
> + * The KPDR_DK only output the key pin level, so it relates to board,
> + * and low level may be active.
> + */
> + if (pdata->direct_key_low_active)
> + new_state = ~KPDK_DK(kpdk) & keypad->direct_key_mask;
> + else
> + new_state = KPDK_DK(kpdk) & keypad->direct_key_mask;
> +
> bits_changed = keypad->direct_key_state ^ new_state;
>
> if (bits_changed == 0)
> --
> 1.7.0.4
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Loop Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2012-04-02 9:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-01 2:08 [PATCH V3 1/4] Input: pxa27x_keypad keep clock on as wakeup source Chao Xie
2012-04-01 2:08 ` [PATCH V3 2/4] Input: pxa27x_keypad bug fix for direct_key_mask Chao Xie
2012-04-02 9:37 ` Haojian Zhuang
2012-04-01 2:08 ` [PATCH V3 3/4] Input: pxa27x_keypad direct key may be low active Chao Xie
2012-04-02 9:38 ` Haojian Zhuang [this message]
2012-04-01 2:08 ` [PATCH V3 4/4] Input: pxa27x_keypad add choice to set direct_key_mask Chao Xie
2012-04-02 9:38 ` Haojian Zhuang
2012-04-02 9:37 ` [PATCH V3 1/4] Input: pxa27x_keypad keep clock on as wakeup source Haojian Zhuang
2012-04-27 9:04 ` Haojian Zhuang
2012-10-28 8:39 ` Vasily Khoruzhick
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAN1soZzcW6Oy_vd3U_WYy9RNL1BLDfG+NpWKg1HUfQDD0eJAUQ@mail.gmail.com \
--to=haojian.zhuang@gmail.com \
--cc=chao.xie@marvell.com \
--cc=dmitry.torokhov@gmail.com \
--cc=eric.y.miao@gmail.com \
--cc=haojian.zhuang@marvell.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).