From mboxrd@z Thu Jan 1 00:00:00 1970 From: Grazvydas Ignotas Subject: Re: [PATCH v2 8/8] DT:omap3+ads7846: use new common touchscreen bindings Date: Mon, 16 Nov 2015 16:37:12 +0200 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: "H. Nikolaus Schaller" Cc: Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , =?UTF-8?Q?Beno=C3=AEt_Cousson?= , Tony Lindgren , Russell King , Dmitry Torokhov , Hans Verkuil , Mauro Carvalho Chehab , Sebastian Reichel , Haibo Chen , Andrey Gelman , Igor Grinberg , Aaron Sierra , Krzysztof Kozlowski , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , gta04-owner-xXXSsgcRVICgSpxsJD1C4w@public.gmane.org, linux-i List-Id: linux-input@vger.kernel.org Hi, On Fri, Nov 13, 2015 at 10:35 PM, H. Nikolaus Schaller wrote: > The standard touch screen bindings [1] replace the private ti,swap-xy > with touchscreen-swaped-x-y. And for the Openpandora we use > touchscreen-size etc. to match the LCD screen size. > > [1]: Documentation/devicetree/bindings/input/touchscreen/touchscreen.= txt > > Signed-off-by: H. Nikolaus Schaller > --- > arch/arm/boot/dts/omap3-lilly-a83x.dtsi | 2 +- > arch/arm/boot/dts/omap3-pandora-common.dtsi | 17 ++++++++++= +++---- > arch/arm/boot/dts/omap3-panel-sharp-ls037v7dw01.dtsi | 2 +- > 3 files changed, 15 insertions(+), 6 deletions(-) > > diff --git a/arch/arm/boot/dts/omap3-lilly-a83x.dtsi b/arch/arm/boot/= dts/omap3-lilly-a83x.dtsi > index d0dd036..01dae66 100644 > --- a/arch/arm/boot/dts/omap3-lilly-a83x.dtsi > +++ b/arch/arm/boot/dts/omap3-lilly-a83x.dtsi > @@ -325,7 +325,7 @@ > ti,y-max =3D /bits/ 16 <3600>; > ti,x-plate-ohms =3D /bits/ 16 <80>; > ti,pressure-max =3D /bits/ 16 <255>; > - ti,swap-xy; > + touchscreen-swapped-x-y; > > linux,wakeup; > }; > diff --git a/arch/arm/boot/dts/omap3-pandora-common.dtsi b/arch/arm/b= oot/dts/omap3-pandora-common.dtsi > index f672a04..9497cc6 100644 > --- a/arch/arm/boot/dts/omap3-pandora-common.dtsi > +++ b/arch/arm/boot/dts/omap3-pandora-common.dtsi > @@ -696,10 +696,19 @@ > pendown-gpio =3D <&gpio3 30 0>; > vcc-supply =3D <&vaux4>; > > - ti,x-min =3D /bits/ 16 <0>; > - ti,x-max =3D /bits/ 16 <8000>; > - ti,y-min =3D /bits/ 16 <0>; > - ti,y-max =3D /bits/ 16 <4800>; > + touchscreen-size-x =3D <800>; > + touchscreen-size-y =3D <480>; > + touchscreen-max-pressure =3D <1000>; > + touchscreen-fuzz-x =3D <16>; > + touchscreen-fuzz-y =3D <16>; > + touchscreen-fuzz-pressure =3D <10>; > + touchscreen-inverted-x; > + touchscreen-inverted-y; > + > + ti,x-min =3D /bits/ 16 <160>; > + ti,x-max =3D /bits/ 16 <3900>; > + ti,y-min =3D /bits/ 16 <220>; > + ti,y-max =3D /bits/ 16 <3750>; I'm not sure this is a good idea, there have been at least 3 different batches of LCDs which slightly different touchscreens attached, with such thresholds we might end up with unreachable touchscreen points on some units. If I understand right, calibration won't help if for some screen locations ADC reading goes below/above these min/max thresholds on some specific units? If so there should probably be at least 10% margin in either case to make calibration useful. Gra=C5=BEvydas -- To unsubscribe from this list: send the line "unsubscribe devicetree" i= n the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html