From: Roderick Colenbrander <roderick@gaikai.com>
To: Simon Wood <simon@mungewell.org>
Cc: linux-input@vger.kernel.org,
Benjamin Tissoires <benjamin.tissoires@redhat.com>,
Jiri Kosina <jikos@kernel.org>, Tim Bird <tim.bird@am.sony.com>,
Roderick Colenbrander <roderick.colenbrander@sony.com>
Subject: Re: [PATCH 2/2] HID: sony: Update device ids
Date: Wed, 5 Oct 2016 21:59:05 -0700 [thread overview]
Message-ID: <CANndSK=SDNjEqFNcAxkM0UGaQdwx1ik0HEVFu9xaMNuqY5FwVA@mail.gmail.com> (raw)
In-Reply-To: <d036f01a80c7d947f2958744ff36a844.squirrel@mungewell.org>
You are right wasn't aware of that. Easy to change tomorrow and will
send an updated version.
On Wed, Oct 5, 2016 at 9:09 PM, Simon Wood <simon@mungewell.org> wrote:
> On Wed, October 5, 2016 8:18 pm, Roderick Colenbrander wrote:
>> From: Roderick Colenbrander <roderick.colenbrander@sony.com>
>>
>>
>> Support additional DS4 model.
>>
>>
>> Signed-off-by: Roderick Colenbrander <roderick.colenbrander@sony.com>
>> ---
>> drivers/hid/hid-ids.h | 1 + drivers/hid/hid-sony.c | 4 ++++ 2 files
>> changed, 5 insertions(+)
>>
>> diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h index
>> cd59c79..27f82cc 100644 --- a/drivers/hid/hid-ids.h
>> +++ b/drivers/hid/hid-ids.h
>> @@ -899,6 +899,7 @@
>> #define USB_DEVICE_ID_SONY_PS3_BDREMOTE 0x0306
>> #define USB_DEVICE_ID_SONY_PS3_CONTROLLER 0x0268
>> #define USB_DEVICE_ID_SONY_PS4_CONTROLLER 0x05c4
>> +#define USB_DEVICE_ID_SONY_PS4_CONTROLLER_2 0x09cc
>> #define USB_DEVICE_ID_SONY_MOTION_CONTROLLER 0x03d5
>> #define USB_DEVICE_ID_SONY_NAVIGATION_CONTROLLER 0x042f
>> #define USB_DEVICE_ID_SONY_BUZZ_CONTROLLER 0x0002
>> diff --git a/drivers/hid/hid-sony.c b/drivers/hid/hid-sony.c index
>> c9916cc..3acdb68 100644 --- a/drivers/hid/hid-sony.c
>> +++ b/drivers/hid/hid-sony.c
>> @@ -2639,6 +2639,10 @@ static const struct hid_device_id sony_devices[] =
>> {
>> .driver_data = DUALSHOCK4_CONTROLLER_USB },
>> { HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_SONY,
>> USB_DEVICE_ID_SONY_PS4_CONTROLLER),
>> .driver_data = DUALSHOCK4_CONTROLLER_BT },
>> + { HID_USB_DEVICE(USB_VENDOR_ID_SONY,
>> USB_DEVICE_ID_SONY_PS4_CONTROLLER_2),
>> + .driver_data = DUALSHOCK4_CONTROLLER_USB },
>> + { HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_SONY,
>> USB_DEVICE_ID_SONY_PS4_CONTROLLER_2),
>> + .driver_data = DUALSHOCK4_CONTROLLER_BT },
>> /* Nyko Core Controller for PS3 */
>> { HID_USB_DEVICE(USB_VENDOR_ID_SINO_LITE,
>> USB_DEVICE_ID_SINO_LITE_CONTROLLER),
>> .driver_data = SIXAXIS_CONTROLLER_USB | SINO_LITE_CONTROLLER },
>
> I think you also need to patch hid-core.c, like:
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/drivers/hid/hid-core.c?id=refs/tags/v4.8#n2057
>
> Great that these patches are coming... thanks.
> Simon
>
--
Roderick Colenbrander
Senior Manager of Software Engineering
Gaikai, a Sony Computer Entertainment Company
roderick@gaikai.com
next prev parent reply other threads:[~2016-10-06 4:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-06 2:18 [PATCH 1/2] HID: sony: Adjust value range for motion sensors Roderick Colenbrander
2016-10-06 2:18 ` [PATCH 2/2] HID: sony: Update device ids Roderick Colenbrander
2016-10-06 4:09 ` Simon Wood
2016-10-06 4:59 ` Roderick Colenbrander [this message]
2016-10-06 18:53 ` Roderick Colenbrander
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANndSK=SDNjEqFNcAxkM0UGaQdwx1ik0HEVFu9xaMNuqY5FwVA@mail.gmail.com' \
--to=roderick@gaikai.com \
--cc=benjamin.tissoires@redhat.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=roderick.colenbrander@sony.com \
--cc=simon@mungewell.org \
--cc=tim.bird@am.sony.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).