Re: [PATCH] HID: input: fix confusion on conflicting mappings

[David Herrmann <dh.herrmann@gmail.com>]

Hi

On Tue, Jan 6, 2015 at 10:19 PM, Jiri Kosina <jkosina@suse.cz> wrote:
> On Mon, 29 Dec 2014, David Herrmann wrote:
>
>> On an PC-101/103/104 keyboard (American layout) the 'Enter' key and its
>> neighbours look like this:
>>
>>            +---+ +---+ +-------+
>>            | 1 | | 2 | |   5   |
>>            +---+ +---+ +-------+
>>              +---+ +-----------+
>>              | 3 | |     4     |
>>              +---+ +-----------+
>
> [ ... snip ... ]
>
> Alright, I can't really see this introducing any regressions. I have now
> queued this for 3.20.

As Fredrik wrote, we need to also check for VARIABLE:

    if (!(field->flags & (HID_MAIN_ITEM_RELATIVE |
                  HID_MAIN_ITEM_BUFFERED_BYTE)) &&
        (field->flags & HID_MAIN_ITEM_VARIABLE) &&
        usage->usage_index < field->maxusage &&
        value == field->value[usage->usage_index]) {

the added line is:

            (field->flags & HID_MAIN_ITEM_VARIABLE) &&

I'll not be at home until tomorrow. Feel free to add it yourself,
otherwise, basic HID keyboards that use ARRAY reports are broken.

Thanks
David